New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 920781 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Move AndroidSmsAppInstallingStatusObserver out of MultiDeviceSetup

Project Member Reported by khorimoto@chromium.org, Jan 10

Issue description

In Azeem's review of [1], he pointed out that there's no reason that AndroidSmsAppInstallingStatusObserver needs to live within the MultiDeviceSetup service. It would be better placed within AndroidSmsService instead, since:
  (1) If Messages is prohibited by policy, MultiDeviceSetupClient does not create an instance of AndroidSmsAppInstallingStatusObserver at all. Since AndroidSmsService is also not created in this case, it makes sense to bundle all of this functionality in the same spot.
  (2) It can rely on MultiDeviceSetupClient to provide all the needed information, so it does not need to be within the implementation of the service.

Since AndroidSmsAppInstallingStatusObserver is the only client of AndroidSmsAppHelperDelegate within the MultiDeviceSetup service, we can also remove the pure virtual AndroidSmsAppHelperDelegate class out of //chromeos/services/multidevice_setup/public/cpp altogether and would no longer need to pass a AndroidSmsAppHelperDelegate* into the service at all.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1402022
 
Labels: -Pri-2 Pri-3

Sign in to add a comment