New issue
Advanced search Search tips

Issue 920750 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[📍] Running pinpoint jobs manually keep failing.

Project Member Reported by ikilpatrick@chromium.org, Jan 10

Issue description

Running pinpoint jobs keep failing with:
Traceback (most recent call last):
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/dashboard/pinpoint/models/job.py", line 364, in Run
    work_left = self.state.ScheduleWork()
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/dashboard/pinpoint/models/job_state.py", line 135, in ScheduleWork
    attempt.ScheduleWork()
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/dashboard/pinpoint/models/attempt.py", line 77, in ScheduleWork
    self._Poll()
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/dashboard/pinpoint/models/attempt.py", line 81, in _Poll
    self._last_execution.Poll()
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/dashboard/pinpoint/models/quest/execution.py", line 95, in Poll
    self._Poll()
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/dashboard/pinpoint/models/quest/read_value.py", line 119, in _Poll
    histograms.ImportDicts(histogram_dicts)
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/tracing/value/histogram_set.py", line 102, in ImportDicts
    hist = histogram_module.Histogram.FromDict(d)
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c2fc5e04.414756318730903365/tracing/value/histogram.py", line 711, in FromDict
    hist.guid = dct['guid']
KeyError: 'guid'



See:
https://pinpoint-dot-chromeperf.appspot.com/job/14341b41940000
https://pinpoint-dot-chromeperf.appspot.com/job/1049a4b9940000
https://pinpoint-dot-chromeperf.appspot.com/job/15b36709940000

Each from a different user.
 
Cc: futhark@chromium.org
I was able to run a pinpoint job on 2019-01-08. After that, all my attempts have failed with the reported stack trace.

Labels: -Pri-3 Pri-2
Another job with the same symptom here:
https://pinpoint-dot-chromeperf.appspot.com/job/12297835940000
Cc: benjhayden@chromium.org
A couple more:

https://pinpoint-dot-chromeperf.appspot.com/job/14decc7d940000
https://pinpoint-dot-chromeperf.appspot.com/job/11a1b9cd940000

+benjhayden as the point of failure appears to be in histograms code.
Guids were recently removed from Histograms:
https://chromium-review.googlesource.com/c/catapult/+/1376610
I deployed the dashboard with this change but not pinpoint.
Dave, can you deploy pinpoint to pick it up?
Status: Fixed (was: Assigned)
I've deployed a new version, and the change should be in.

Sign in to add a comment