New issue
Advanced search Search tips

Issue 920742 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Reloading WebXR page while session request is live crashes Chrome

Project Member Reported by tiborg@chromium.org, Jan 10

Issue description

If a WebXR page gets reloaded / navigated away while a session request is open (e.g. while the VR DFM is installing) we hit a DCHECK. To fix that we should close all open session request when destroying the GvrDevice.
 

Comment 1 by tiborg@chromium.org, Jan 16 (6 days ago)

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320281ab7e34c8baff685ff809664f0e48c9f200

commit 320281ab7e34c8baff685ff809664f0e48c9f200
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Jan 17 16:56:44 2019

[vr] Close pending session request when destroying GVR device

Bug:  920742 
Change-Id: I44f50fb0ea89ad5c75fbb2d338330651703ba4bb
Reviewed-on: https://chromium-review.googlesource.com/c/1416613
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623722}
[modify] https://crrev.com/320281ab7e34c8baff685ff809664f0e48c9f200/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/320281ab7e34c8baff685ff809664f0e48c9f200/device/vr/android/gvr/gvr_device.h

Comment 3 by tiborg@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Started)

Sign in to add a comment