New issue
Advanced search Search tips

Issue 920739 link

Starred by 1 user
Status: Verified
Owner:
mrsuyi@chromium.org
Closed: Jan 16
Cc:
mrsuyi@chromium.org
edchin@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Tab Switcher is not displayed correctly in landscape mode.

Project Member Reported by srikanthg@chromium.org, Jan 10 
App Version: 73.0.3667.0 canary
iOS Version: 12.1.3, 12.1.2
Device: iPhoneX, iPhone7 plus
URL: NA

Steps to reproduce:
  1. Launch Google Chrome in portrait mode
  2. Rotate the device to landscape mode
  3. Enter tab switcher

Observed results: Observe that a black bottom bar is displayed

Good Version: M73.0.3666.0 #4ba3d24 
 Bad Version: M73.0.3667.0 #1132c58

Expected results: Tab Switcher UI should be displayed correctly.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: , Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M71 NO
Bug reproducible on the current beta channel build (App Version, iOS Version): M72 NO


Link to video/image: https://drive.google.com/a/google.com/file/d/1n5w5eA2eMfB--SlNLJT3MNuPxJhsOWrj/view?usp=drive_open

Comment 1 by mrsuyi@chromium.org, Jan 11

Owner: mrsuyi@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c857442fcadb84aef4a606dad44fb5050de478b

commit 2c857442fcadb84aef4a606dad44fb5050de478b
Author: Yi Su <mrsuyi@chromium.org>
Date: Wed Jan 16 09:22:30 2019

Fix bug of black bottom toolbar in landscape mode.

When tab grid is opened in landscape mode on iPhone, the bottom toolbar
has a black background instead of a transparent background. This is
caused by setting toolbar background to UIColor.blackColor in
TabGridBottomToolbar.hide(). This CL fixes it and doesn't affect the
tab grid transition animation.

This CL also sets the background for remote pages of tab grid in
TabGridBottomToolbar.updateLayout(), which solves another potential bug.

Bug:  920739 
Change-Id: I9d84650b3a4e68796bb763fe87cb750afcd296e3
Reviewed-on: https://chromium-review.googlesource.com/c/1406809
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623168}
[modify] https://crrev.com/2c857442fcadb84aef4a606dad44fb5050de478b/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm

Comment 3 by mrsuyi@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Started)

Comment 4 by vbhatso...@chromium.org, Today (9 hours ago)

Status: Verified (was: Fixed)
Verified on iPhone XSMAX iOS 12.0.1 on build 73.0.3680.0 Canary .
Tabs in Tab Switcher mode in landscape orientation looks good.
►

Sign in to add a comment