Findit identified the culprit r621523 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTBmM2QxNjRjN2JiMjZiNzY3N2NkZGMzMGIyZTFmNzQwZDY4NTQyZAw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r621523&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTBmM2QxNjRjN2JiMjZiNzY3N2NkZGMzMGIyZTFmNzQwZDY4NTQyZAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14dfc0eebaef51c5156fc662a76be399bd336c3b commit 14dfc0eebaef51c5156fc662a76be399bd336c3b Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Jan 10 21:03:36 2019 Revert "Reland: sync_integration_tests: don't instantiate ScopedFeatureList in test body" This reverts commit a0f3d164c7bb26b7677cddc30b2e1f740d68542d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 621523 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTBmM2QxNjRjN2JiMjZiNzY3N2NkZGMzMGIyZTFmNzQwZDY4NTQyZAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/32409 Sample Failed Step: sync_integration_tests Sample Flaky Test: SingleClientWalletWithAccountStorageSyncTest.SwitchesBetweenAccountAndProfileStorageOnTogglingSync Original change's description: > Reland: sync_integration_tests: don't instantiate ScopedFeatureList in test body > > This is a reland of https://crrev.com/c/1402799. The original CL was > reverted for supposedly introducing flakiness, but in fact in only > renamed an already-flaky test. That test has since been disabled, so > trying again. > > Creating a ScopedFeatureList instance in the test body creates a data > race related to the global FeatureList instance: The ScopedFeatureList > overrides the global instance, and then it gets reset after the test > body; however, the feature list might still be queried from the Sync > thread after that. > > This CL avoids the issue by instead creating test (sub)classes to hold > the ScopedFeatureLists. > > Bug: 915219 > Change-Id: Iaa6185d0dd9a042a9275100e3b1cae1eceb52633 > Reviewed-on: https://chromium-review.googlesource.com/c/1402890 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621523} Change-Id: I3c8804e10fc6fd5c15e540f4b0441926da421634 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 915219 , 920738 Reviewed-on: https://chromium-review.googlesource.com/c/1405984 Cr-Commit-Position: refs/heads/master@{#621737} [modify] https://crrev.com/14dfc0eebaef51c5156fc662a76be399bd336c3b/chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc [modify] https://crrev.com/14dfc0eebaef51c5156fc662a76be399bd336c3b/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc [modify] https://crrev.com/14dfc0eebaef51c5156fc662a76be399bd336c3b/chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc [modify] https://crrev.com/14dfc0eebaef51c5156fc662a76be399bd336c3b/chrome/browser/sync/test/integration/single_client_user_consents_sync_test.cc [modify] https://crrev.com/14dfc0eebaef51c5156fc662a76be399bd336c3b/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
The test was already flaky on TSan [1], my CL just renamed it. I'll disable it. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sync_integration_tests&tests=SwitchesBetweenAccountAndProfileStorageOnTogglingSync
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1f5e2dfdc3427684524904abd49c98a0fa05b88 commit a1f5e2dfdc3427684524904abd49c98a0fa05b88 Author: Marc Treib <treib@chromium.org> Date: Fri Jan 11 11:06:57 2019 Disable SingleClientWalletSyncTest.SwitchesBetweenAccountAndProfile... on TSan It's flaky due to an SQLite data race. Bug: 920738 , 917380 Change-Id: I3ed269d487daa25ebd973bda8b1689ebd22977ec Reviewed-on: https://chromium-review.googlesource.com/c/1406708 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#621968} [modify] https://crrev.com/a1f5e2dfdc3427684524904abd49c98a0fa05b88/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
Comment 1 by bugdroid1@chromium.org
, Jan 10