New issue
Advanced search Search tips

Issue 920732 link

Starred by 3 users
Status: Assigned
Owner:
lgrey@chromium.org
Cc:
maxwalker@chromium.org
rfeng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 850098



Sign in to add a comment

[Dark mode] Autofill secondary UI

Project Member Reported by namratakannan@chromium.org, Jan 10 
Autofill does not show the text for "manage passwords" and "manage payments"

New background color:
GG700


Image attached with spec
ccing rfeng and maxwalker for their approval.
Passwords-Dark mode-Today.png
80.8 KB View Download
Passwords.png
175 KB View Download
Autofill dropdown.png
203 KB View Download

Comment 1 by lgrey@chromium.org, Jan 10

Owner: lgrey@chromium.org

Comment 2 by lgrey@chromium.org, Jan 10

Status: Assigned (was: Available)

Comment 3 by lgrey@chromium.org, Jan 14

Blocking: 850098
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/747611a103ca60cf4714b4a164dbbc57ddb872cb

commit 747611a103ca60cf4714b4a164dbbc57ddb872cb
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Jan 14 20:42:14 2019

Dark mode: update menu hover colors

HighlightedMenuItemBackgroundColor covers the autofill popup footer.

Bug: 920732
Change-Id: Ib7689ae55a4dbd1ef6733312a26080dcb1ddd071
Reviewed-on: https://chromium-review.googlesource.com/c/1409356
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622587}
[modify] https://crrev.com/747611a103ca60cf4714b4a164dbbc57ddb872cb/ui/native_theme/common_theme.cc

Comment 5 by robliao@chromium.org, Jan 17 (6 days ago)

Labels: Hotlist-DesktopUIConsider

Comment 6 by robliao@chromium.org, Jan 18 (5 days ago)

Labels: Group-Dark_Mode

Comment 7 by namratakannan@chromium.org, Jan 18 (4 days ago) 

Text color for the footer should GG200
Looks like currently it is GG500
Screen Shot 2019-01-18 at 10.24.51 AM.png
67.9 KB View Download

Comment 8 by namratakannan@chromium.org, Yesterday (24 hours ago) 

And update the footer color to GG800
►

Sign in to add a comment