WebAPK shows network error dialog after splash screen is hidden |
|
Issue descriptionRepro steps: 1) Hack WebAPK for https://wrong.host.badssl.com 2) Launch WebAPK Expected: Either network error dialog does not show or splash screen stays up and network error dialog is shown Actual: Splash screen hides but network error dialog is shown. See screenshot
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d62b308f2c3add3fccf15677d17c9bd2c2d75855 commit d62b308f2c3add3fccf15677d17c9bd2c2d75855 Author: Clark DuVall <cduvall@chromium.org> Date: Mon Jan 14 20:10:01 2019 Revert "[Android WebAPK] Do not hide splash screen when network error dialog is up" This reverts commit 103d54a8f36de64dbf1bce6930c3121bacdd076e. Reason for revert: This broke chrome_public_test_apk with --enable-features=NetworkService: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Android/12411 Related failures: org.chromium.chrome.browser.webapps.WebApkIntegrationTest#testLaunchAndNavigationInNewWindowOffandInOrigin org.chromium.chrome.browser.webapps.WebApkIntegrationTest#testLaunchAndOpenNewWindowInOrigin These are timing out on the waitUntilSplashscreenHides(); call. Original change's description: > [Android WebAPK] Do not hide splash screen when network error dialog is up > > This CL changes the splash screen hiding logic to not hide the splash screen > while the network error dialog is up. > > BUG=920729 > > Change-Id: Ifa4659b2e97c70b5d4dde83ba52b3bd41a80ea29 > Reviewed-on: https://chromium-review.googlesource.com/c/1405985 > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622103} TBR=pkotwicz@chromium.org,dominickn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920729 Change-Id: I0acb0616e7786926d90ac8f8b10adaf0b3c6f01f Reviewed-on: https://chromium-review.googlesource.com/c/1409692 Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#622566} [modify] https://crrev.com/d62b308f2c3add3fccf15677d17c9bd2c2d75855/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappOfflineDialog.java [modify] https://crrev.com/d62b308f2c3add3fccf15677d17c9bd2c2d75855/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappSplashScreenController.java
,
Jan 21
(2 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1091960ca9aedbd696e3efe80e2523b827242b1 commit a1091960ca9aedbd696e3efe80e2523b827242b1 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Mon Jan 21 00:37:38 2019 Reland [Android WebAPK] Do not hide splash screen when network error dialog is up [Android WebAPK] Do not hide splash screen when network error dialog is up This CL changes the splash screen hiding logic to not hide the splash screen while the network error dialog is up. Initial CL https://chromium-review.googlesource.com/c/chromium/src/+/1405985 BUG=920729 Change-Id: Id5a7b0279c049ba4ad6076f3a79145792bab3b40 Reviewed-on: https://chromium-review.googlesource.com/c/1417277 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#624498} [modify] https://crrev.com/a1091960ca9aedbd696e3efe80e2523b827242b1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkOfflineDialog.java [modify] https://crrev.com/a1091960ca9aedbd696e3efe80e2523b827242b1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappSplashScreenController.java [modify] https://crrev.com/a1091960ca9aedbd696e3efe80e2523b827242b1/testing/buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Jan 11