Issue metadata
Sign in to add a comment
|
SingleProcessMash: Unable to Rename file while saving it |
||||||||||||||||||||||
Issue descriptionChrome Version: 11151.100.0, 71.0.3578.120 Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Search for any image (2) Try to save image or download the image (3) Try to Rename the image while saving it and observe Expected Result: Image should be renamed Actual Result: Unable to rename the image How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? No workaround Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 11
This seems to only occur with SingleProcessMash and only while running in a select file dialogs - opening the files app normally works as expected.
,
Jan 11
sky / xiyuan / msw - this looks like an input event issue. Maybe another IME problem? Can one of you take this?
,
Jan 11
,
Jan 11
sammc, the bug report says version 71.0.3578.120. SingleProcessMash should not be enabled by default in M71, only in M73 dev. What version did you try?
,
Jan 11
,
Jan 11
Having a fix: https://chromium-review.googlesource.com/c/chromium/src/+/1407196 Now figuring out how to add a test.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29ffac3e6b53c76da1aeeabf1dfcd7570297f163 commit 29ffac3e6b53c76da1aeeabf1dfcd7570297f163 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Jan 14 18:15:39 2019 SPM: Fix ExtensionViewHost key event not working The problem is similar to WebDialogView in https://crbug.com/919183 that ExtensionViewHost does return a proper "handled/procssed" flag for the unhandled key events. The CL makes it to return the flag from ExtensionView instead of always returning true. Bug: 920713 Change-Id: I9ee61c0ba5b390e43a20fce38d7393e26fe3d847 Reviewed-on: https://chromium-review.googlesource.com/c/1407196 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#622513} [modify] https://crrev.com/29ffac3e6b53c76da1aeeabf1dfcd7570297f163/chrome/browser/extensions/extension_view_host.cc [modify] https://crrev.com/29ffac3e6b53c76da1aeeabf1dfcd7570297f163/chrome/browser/extensions/extension_view_host.h [add] https://crrev.com/29ffac3e6b53c76da1aeeabf1dfcd7570297f163/chrome/browser/ui/views/content_test_utils.cc [add] https://crrev.com/29ffac3e6b53c76da1aeeabf1dfcd7570297f163/chrome/browser/ui/views/content_test_utils.h [add] https://crrev.com/29ffac3e6b53c76da1aeeabf1dfcd7570297f163/chrome/browser/ui/views/extensions/extension_dialog_browsertest.cc [modify] https://crrev.com/29ffac3e6b53c76da1aeeabf1dfcd7570297f163/chrome/browser/ui/views/web_dialog_view_browsertest.cc [modify] https://crrev.com/29ffac3e6b53c76da1aeeabf1dfcd7570297f163/chrome/test/BUILD.gn
,
Jan 14
,
Jan 14
Issue is verified in 11578.0.0, 73.0.3669.0
,
Jan 15
Not verified yet. Chrome has yet to roll |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by spathangi@chromium.org
, Jan 10