New issue
Advanced search Search tips

Issue 920706 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Move download service task scheduler to a common target

Project Member Reported by shaktisahu@chromium.org, Jan 10

Issue description

Since background download service and download auto-resumptions both depend on task scheduler, we can probably move them to a common target.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d08ffba4ec906d29301d8973ecb99edd7168544

commit 8d08ffba4ec906d29301d8973ecb99edd7168544
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri Jan 11 00:29:22 2019

Moved download task scheduler out of background_service

Since both download service and auto-resumptions depend on task scheduler
and task manager, it would be ideal to move them out to a common directory.
This CL moves them out to //components/download/public/task

Bug:  920706 
Change-Id: I81b06d9d4e4d577fed48ee8e9c57600ee7b4a793
Reviewed-on: https://chromium-review.googlesource.com/c/1405544
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621826}
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/chrome/android/BUILD.gn
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/chrome/browser/android/download/service/download_task_scheduler.h
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/chrome/browser/download/download_service_factory.cc
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/chrome/browser/download/download_task_scheduler_impl.h
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/BUILD.gn
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/content/factory/download_service_factory.cc
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/internal/background_service/BUILD.gn
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/internal/background_service/controller.h
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/internal/background_service/controller_impl.h
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/internal/background_service/scheduler/scheduler_impl.cc
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/internal/background_service/scheduler/scheduler_impl_unittest.cc
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/internal/background_service/stats.h
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/background_service/BUILD.gn
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/background_service/download_service.h
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/common/auto_resumption_handler.cc
[modify] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/common/auto_resumption_handler.h
[add] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/BUILD.gn
[rename] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/download_task_types.h
[rename] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/empty_task_scheduler.cc
[rename] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/empty_task_scheduler.h
[rename] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/task_manager.cc
[rename] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/task_manager.h
[rename] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/task_manager_unittest.cc
[rename] https://crrev.com/8d08ffba4ec906d29301d8973ecb99edd7168544/components/download/public/task/task_scheduler.h

Status: Fixed (was: Unconfirmed)

Sign in to add a comment