New issue
Advanced search Search tips

Issue 920701 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tast tests failing for new HiDPI scaling test

Project Member Reported by jkardatzke@chromium.org, Jan 10

Issue description

Since Chrome OS R73-11555.0.0

Example is here: https://stainless.corp.google.com/browse/chromeos-autotest-results/275515313-chromeos-test/

This fails only on certain boards, not chipset specific (works on kevin, fails on bob)

The specific failure message is: High density size {100 100} is not smaller than low density size {100 100}

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e40edb957ebc015b04a175b27e6836d461a4aa

commit e9e40edb957ebc015b04a175b27e6836d461a4aa
Author: Tim Zheng <timzheng@google.com>
Date: Tue Jan 15 03:25:17 2019

Add autotest API for getting scale factor.

To get the primary display's scale factor. This is helpful in determine
if the Crostini wayland_demo app window size actually scale up when in
low display density mode.

BUG=chromium:839242; chromium:920701
TEST=unit test included in this CL

Change-Id: Iea55dc0d6e3cb47aacbac7fe21ceed9a81b9188e
Reviewed-on: https://chromium-review.googlesource.com/c/1407959
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622709}
[modify] https://crrev.com/e9e40edb957ebc015b04a175b27e6836d461a4aa/chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/e9e40edb957ebc015b04a175b27e6836d461a4aa/chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.h
[modify] https://crrev.com/e9e40edb957ebc015b04a175b27e6836d461a4aa/chrome/common/extensions/api/autotest_private.idl
[modify] https://crrev.com/e9e40edb957ebc015b04a175b27e6836d461a4aa/chrome/test/data/extensions/api_test/autotest_private/test.js
[modify] https://crrev.com/e9e40edb957ebc015b04a175b27e6836d461a4aa/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/e9e40edb957ebc015b04a175b27e6836d461a4aa/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/aec7d36aaf9cbceed439a7e4b80f51256ac7d3d4

commit aec7d36aaf9cbceed439a7e4b80f51256ac7d3d4
Author: Tim Zheng <timzheng@google.com>
Date: Fri Jan 18 04:20:38 2019

tast: Fix Crostini app display density test.

The Crostini app display density test is failing on the boards that have
primary display scale factor of 1.0. The X11_demo app shows the same
window size in high or low display density setting on that condition.
This fix uses the scale factor to treat those boards differently.
BUG=chromium:839242; chromium:920701
TEST=Ran the tast test on both eve and kefka machines.

Change-Id: I3dd833b83a666824c952dc0bd404cba7919b66dc
Reviewed-on: https://chromium-review.googlesource.com/1413872
Commit-Ready: Tim Zheng <timzheng@chromium.org>
Tested-by: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>

[modify] https://crrev.com/aec7d36aaf9cbceed439a7e4b80f51256ac7d3d4/src/chromiumos/tast/local/bundles/cros/vm/subtest/display_density.go

Sign in to add a comment