New issue
Advanced search Search tips

Issue 920698 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Jan 14
Cc:
pdr@chromium.org
caseq@chromium.org
paulir...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Layers panel in devtools Performance/Frames is broken

Project Member Reported by wangxianzhu@chromium.org, Jan 10 
1. Open devtools for any web page
2. Switch to Performance panel
3. Click the gear icon on the right of the tool bar
4. Check "Enable advanced paint instrumentation (slow)"
5. Click record icon
6. resize the window etc. to make some frames
7. Stop recording
8. Expand "Frames"
9. Click above the frame thumbnail
10. Choose the Layers panel below the captured result

Expected: The Layers panel shows layer tree.

Actual: "Layer information is not yet available"

[139847:139847:0110/110813.923075:INFO:CONSOLE(31)] "Uncaught (in promise) TypeError: Cannot read property '0' of undefined", source: http://127.0.0.1:43437/devtools/timeline_model/timeline_model_module.js (31)

It's a recent regression: https://chromium.googlesource.com/chromium/src/+log/15f20f48842d18ebd868891cd44a7a7e34864713..2a8d0d3bf84178c0f127ab957c8395c7a32776a9

Comment 1 by wangxianzhu@chromium.org, Jan 10

Cc: pdr@chromium.org
Owner: wangxianzhu@chromium.org
I will fix this and ensure fixing bug 916768 won't break this again.

Comment 2 by wangxianzhu@chromium.org, Jan 10

Cc: caseq@chromium.org paulir...@chromium.org
I'm not sure how the CL caused the regression, but currently the issue is because that we don't have a drawsContent root layer. For now to keep compatibility of layer tree and layer list, I think we should always display the root layer regardless of its drawsContent status and showInternalLayers setting. I would like to remove showInternalLayers setting to make non-drawsContent root layer work. We have fewer internal layers in BlinkGenPropertyTrees, and no internal layers in CompositeAfterPaint.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeea36a3be80dd7636cca27f90562bf2b07a4460

commit aeea36a3be80dd7636cca27f90562bf2b07a4460
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon Jan 14 18:23:35 2019

[PE] Fix DevTools Performance/Frames/Layers

The DevTools front-end still expect the renderer output Position.

Bug:  920698 
Change-Id: I4c03167fcdcbe78ab2dfefc5e7912d263fd49ce7
Reviewed-on: https://chromium-review.googlesource.com/c/1407659
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622518}
[modify] https://crrev.com/aeea36a3be80dd7636cca27f90562bf2b07a4460/cc/layers/layer_impl.cc

Comment 4 by wangxianzhu@chromium.org, Jan 14

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0e0e3b5f844cbe32fea55f63300b8f727f50282

commit e0e0e3b5f844cbe32fea55f63300b8f727f50282
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Jan 16 07:38:57 2019

Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer

This prepares for CompositeAfterPaint because GraphicsLayer will
disappear.

- Move compositing_reasons, owner_node_id and paint_count from
  GraphicsLayer into cc::Layer.

- Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer.

- To support layer lists, cheat devtools front-end by setting
  drawsContent to true for the root layer, to let devtools can find
  the contentRoot correctly.

Bug:  920698 ,916768
Change-Id: I0f1c7c73a5c1a5c491f5d0986d8f38558a67540f
Reviewed-on: https://chromium-review.googlesource.com/c/1391351
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623147}
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/cc/layers/layer.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/cc/layers/layer.h
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/cc/layers/picture_layer.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/frame/frame_overlay.h
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.h
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/web_tests/http/tests/devtools/layers/layer-canvas-log-expected.txt
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/web_tests/http/tests/devtools/layers/layer-tree-model-expected.txt
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/web_tests/http/tests/devtools/layers/layers-3d-view-hit-testing-expected.txt
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/web_tests/http/tests/devtools/layers/layers-3d-view-hit-testing.js
[modify] https://crrev.com/e0e0e3b5f844cbe32fea55f63300b8f727f50282/third_party/blink/web_tests/inspector-protocol/layers/paint-profiler-expected.txt
[delete] https://crrev.com/4cfcfb7e679f7b406834b73c9e9cabde1e82a3f3/third_party/blink/web_tests/platform/win7/virtual/threaded/http/tests/devtools/tracing/timeline-paint/layer-tree-expected.txt
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/619972bd959e47fecd4f16dc8bde0eaed0137efa

commit 619972bd959e47fecd4f16dc8bde0eaed0137efa
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Wed Jan 16 09:15:35 2019

Revert "Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer"

This reverts commit e0e0e3b5f844cbe32fea55f63300b8f727f50282.

Reason for revert: compile failure on android. 
See https://crbug.com/922381

Original change's description:
> Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer
> 
> This prepares for CompositeAfterPaint because GraphicsLayer will
> disappear.
> 
> - Move compositing_reasons, owner_node_id and paint_count from
>   GraphicsLayer into cc::Layer.
> 
> - Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer.
> 
> - To support layer lists, cheat devtools front-end by setting
>   drawsContent to true for the root layer, to let devtools can find
>   the contentRoot correctly.
> 
> Bug:  920698 ,916768
> Change-Id: I0f1c7c73a5c1a5c491f5d0986d8f38558a67540f
> Reviewed-on: https://chromium-review.googlesource.com/c/1391351
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623147}

TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org,caseq@chromium.org

Change-Id: Ic057ee027b663c6d9905b62d25ec74aa9851ba5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  920698 , 916768, 922381
Reviewed-on: https://chromium-review.googlesource.com/c/1412023
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623166}
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/cc/layers/layer.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/cc/layers/layer.h
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/cc/layers/picture_layer.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/frame/frame_overlay.h
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.h
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/web_tests/http/tests/devtools/layers/layer-canvas-log-expected.txt
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/web_tests/http/tests/devtools/layers/layer-tree-model-expected.txt
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/web_tests/http/tests/devtools/layers/layers-3d-view-hit-testing-expected.txt
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/web_tests/http/tests/devtools/layers/layers-3d-view-hit-testing.js
[modify] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/web_tests/inspector-protocol/layers/paint-profiler-expected.txt
[add] https://crrev.com/619972bd959e47fecd4f16dc8bde0eaed0137efa/third_party/blink/web_tests/platform/win7/virtual/threaded/http/tests/devtools/tracing/timeline-paint/layer-tree-expected.txt
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b86841965a5b084cb9f6a1ffe8a4042911e28ff3

commit b86841965a5b084cb9f6a1ffe8a4042911e28ff3
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jan 17 00:51:13 2019

Reland "Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer"

This reverts commit 619972bd959e47fecd4f16dc8bde0eaed0137efa.

Original change's description:
> Revert "Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer"
>
> This reverts commit e0e0e3b5f844cbe32fea55f63300b8f727f50282.
>
> Reason for revert: compile failure on android.
> See https://crbug.com/922381
>
> Original change's description:
> > Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer
> >
> > This prepares for CompositeAfterPaint because GraphicsLayer will
> > disappear.
> >
> > - Move compositing_reasons, owner_node_id and paint_count from
> >   GraphicsLayer into cc::Layer.
> >
> > - Let InspectorLayerTreeAgent use cc::Layer instead of GraphicsLayer.
> >
> > - To support layer lists, cheat devtools front-end by setting
> >   drawsContent to true for the root layer, to let devtools can find
> >   the contentRoot correctly.
> >
> > Bug:  920698 ,916768
> > Change-Id: I0f1c7c73a5c1a5c491f5d0986d8f38558a67540f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1391351
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Reviewed-by: vmpstr <vmpstr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#623147}
>
> TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org,caseq@chromium.org
>
> Change-Id: Ic057ee027b663c6d9905b62d25ec74aa9851ba5d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  920698 , 916768, 922381
> Reviewed-on: https://chromium-review.googlesource.com/c/1412023
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623166}

TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org,caseq@chromium.org,arthursonzogni@chromium.org

Change-Id: I555434b005dcd8cf2000effe860012c419a675e4
Bug:  920698 , 916768, 922381
Reviewed-on: https://chromium-review.googlesource.com/c/1414765
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623474}
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/cc/layers/layer.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/cc/layers/layer.h
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/cc/layers/picture_layer.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/frame/frame_overlay.h
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.h
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/web_tests/http/tests/devtools/layers/layer-canvas-log-expected.txt
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/web_tests/http/tests/devtools/layers/layer-tree-model-expected.txt
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/web_tests/http/tests/devtools/layers/layers-3d-view-hit-testing-expected.txt
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/web_tests/http/tests/devtools/layers/layers-3d-view-hit-testing.js
[modify] https://crrev.com/b86841965a5b084cb9f6a1ffe8a4042911e28ff3/third_party/blink/web_tests/inspector-protocol/layers/paint-profiler-expected.txt
[delete] https://crrev.com/a88fb569a28da1f4a3c45dfc792e43c981637848/third_party/blink/web_tests/platform/win7/virtual/threaded/http/tests/devtools/tracing/timeline-paint/layer-tree-expected.txt
►

Sign in to add a comment