Navi A11y - Incorrect focus when navigating between modules |
|||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Launch chrome with Navi enabled 2. Use NVDA to navigate chrome://welcome What is the expected result? When navigating through the wizard, we expect the heading to be read. What happens instead of that? Silence after clicking "Next" or "Skip"
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eba69eb1c3958bd58a655b24dfb274396d4d8a7b commit eba69eb1c3958bd58a655b24dfb274396d4d8a7b Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Jan 11 20:03:21 2019 Navi A11y - Focus Heading in each step of onboarding for screen readers. Bug: 920685 Change-Id: Ibbb068b85f5bd3a94b5823dbece9409ea68bcb36 Reviewed-on: https://chromium-review.googlesource.com/c/1406180 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#622118} [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.html [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.js [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/eba69eb1c3958bd58a655b24dfb274396d4d8a7b/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html
,
Jan 14
Requesting Merge. Fix is isolated to onboarding webui, this is required for a11y and should be fairly low risk. We can turn off entire feature with a flag if necessary.
,
Jan 14
,
Jan 14
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 14
By flag, do you mean turning off the entire Project Navi flag or is this more isolated to WebUI? Have you verified this in canary?
,
Jan 14
Yes, this is the entire Project Navi Flag. Also verified that this works as expected on Canary 73.0.3671.1
,
Jan 15
Approving merge - 3626
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878 commit b9237b4cb9aedc6f0d1ca28c45910d687ce3e878 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Jan 15 21:59:18 2019 Navi A11y - Focus Heading in each step of onboarding for screen readers. (cherry picked from commit eba69eb1c3958bd58a655b24dfb274396d4d8a7b) Bug: 920685 Change-Id: Ibbb068b85f5bd3a94b5823dbece9409ea68bcb36 Reviewed-on: https://chromium-review.googlesource.com/c/1406180 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622118} Reviewed-on: https://chromium-review.googlesource.com/c/1413014 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#699} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.html [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.js [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9237b4cb9aedc6f0d1ca28c45910d687ce3e878 Commit: b9237b4cb9aedc6f0d1ca28c45910d687ce3e878 Author: hcarmona@chromium.org Commiter: hcarmona@chromium.org Date: 2019-01-15 21:59:18 +0000 UTC Navi A11y - Focus Heading in each step of onboarding for screen readers. (cherry picked from commit eba69eb1c3958bd58a655b24dfb274396d4d8a7b) Bug: 920685 Change-Id: Ibbb068b85f5bd3a94b5823dbece9409ea68bcb36 Reviewed-on: https://chromium-review.googlesource.com/c/1406180 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622118} Reviewed-on: https://chromium-review.googlesource.com/c/1413014 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#699} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 15
Should be fixed when we get our next beta build
,
Jan 16
(6 days ago)
Able to reproduce this issue on Windows 10 on the build without Fix 72.0.3626.53 and the issue is fixed on the latest M-72 build 72.0.3626.64. 1. Enabled NVDA and Launched Chrome with flag --enable-features=NuxOnboardingForceEnabled. 2. Navigated to chrome://welcome and clicked on Get Started button. 3. Clicked on the Skip/Next buttons and on the entering the next page, NVDA is reading out 'Save your progress' heading. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hcarmona@chromium.org
, Jan 10