New issue
Advanced search Search tips

Issue 920684 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

PDFAnnotationsTest.AnnotationsFeatureEnabled failing on chromium.memory/Linux ChromiumOS MSan Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 10

Issue description

Cc: adithyas@chromium.org shend@chromium.org
Owner: dstockwell@chromium.org
dstockwell@: This test appears to be timing out, I suspect https://chromium-review.googlesource.com/c/chromium/src/+/1404214 is causing it, but there are some other annotation commits you've landed, so I'm not sure which one is the cause.

Would you mind taking a look and fixing it? I'm going to disable the test meanwhile.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652b8caa007bd4626ef65a09356b0beeb80308bd

commit 652b8caa007bd4626ef65a09356b0beeb80308bd
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Jan 10 19:05:46 2019

Disable PDFAnnotationsTest.AnnotationsFeatureEnabled

No-Try: true
Tbr: dstockwell@chromium.org
Bug:  920684 
Change-Id: Ie02148ecc672012987945363ed08e2599ba4e0df
Reviewed-on: https://chromium-review.googlesource.com/c/1405888
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621680}
[modify] https://crrev.com/652b8caa007bd4626ef65a09356b0beeb80308bd/chrome/browser/pdf/pdf_extension_test.cc

Owner: dstockwell@google.com
This is very likely due to the use of WebGL to render the PDF in annotation mode.

https://www.chromium.org/developers/testing/memorysanitizer that the use of osmeta is known to be slow.

I'm going to re-enable on outside of sanitizer builds.
Components: Internals>Plugins>PDF
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82b1bdb93f62bd6f4454a96eff1689a284ea297e

commit 82b1bdb93f62bd6f4454a96eff1689a284ea297e
Author: dstockwell <dstockwell@google.com>
Date: Fri Jan 11 02:10:58 2019

Disable PDFAnnotationsTest.AnnotationsFeatureEnabled for sanitizer

Timeouts are likely due to to the use of WebGL to render the PDF in
annotation mode.

https://www.chromium.org/developers/testing/memorysanitizer notes
that the use of osmesa is known to be slow.

Bug:  920684 
Change-Id: I141738cae4cb97da73f0af2fb434a6fbffef6e71
Reviewed-on: https://chromium-review.googlesource.com/c/1405154
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621869}
[modify] https://crrev.com/82b1bdb93f62bd6f4454a96eff1689a284ea297e/chrome/browser/pdf/pdf_extension_test.cc

Labels: -Sheriff-Chromium

Comment 8 by dstockwell@google.com, Jan 16 (6 days ago)

Status: Fixed (was: Assigned)
Due to the GL performance of these test configurations, this test will remain permanently disabled there.

Sign in to add a comment