Issue metadata
Sign in to add a comment
|
Regression: Car images do not paint on carvana.com [Intersection Observer] |
||||||||||||||||||||
Issue descriptionLoad https://www.carvana.com/cars/ford-edge/titanium?cvnaid=eyJmaWx0ZXJzIjp7InRleHRTZWFyY2hJbnB1dHMiOlsiZm9yZCBlZGdlIHRpdGFuaXVtIl19LCJmaWx0ZXJTb3VyY2UiOjExfQ%3D%3D Observe: Car images do not paint. python tools/bisect-builds.py -a win64 -g 599034 -b 621406 -- --no-first-run --user-data-dir=/temp https://www.carvana.com/cars/ford-edge/titanium?cvnaid=eyJmaWx0ZXJzIjp7InRleHRTZWFyY2hJbnB1dHMiOlsiZm9yZCBlZGdlIHRpdGFuaXVtIl19LCJmaWx0ZXJTb3VyY2UiOjExfQ%3D%3D You are probably looking for a change made after 613615 (known good), but no later than 613626 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/2fa80cc387adad473de8a55d2cd39f169e825495..77ce157f5f3a43c6e7d78e37d778335b5d393c6b Manually reverting https://chromium.googlesource.com/chromium/src/+/5aeac688156a067eeac628f056e05065134fcc2e resolves this issue.
,
Jan 10
Regressing CL was merged to 72 and 72.0.3626.53 Beta reproduces the problem.
,
Jan 10
The problematic code on the site appears to be related to the following inside https://assets.cvnaassets.com/serenity/js/main.26f67ab24eaaa378555a.chunk.js var sf=k.default.div.attrs({"data-qa":"fade-in"}).withConfig({displayName:"LazyLoadIntersectionObserverComponent__FadeIn",componentId:"kqgq39-0"})(["transition:opacity 1000ms ease;opacity:",";"],function(e){return e.isIntersecting?1:0}) If the function(e) always returns 1, the images render just fine.
,
Jan 10
https://www.bayden.com/test/intersection/920674.html demonstrates the differing behavior between Firefox/Edge18/Chrome71 vs Chrome72 and later. See the console for logging messages as you interact with the various buttons.
,
Jan 11
RBS to highlight a regression close to getting to stable whose impact we should evaluate. It looks like the bug this fixed was also a regression: issue 910741 Chris / Stephan WDYT?
,
Jan 14
[bulk update] Just a heads up, M72 stable is about 2 weeks away. This issue is marked as RB-Stable. Please take a look.
,
Jan 14
,
Jan 15
Able to reproduce the issue on Win10/64 bit - 72.0.3626.53 Beta Build 1. Navigated to the URl https://www.carvana.com/cars/ford-edge/titanium?cvnaid=eyJmaWx0ZXJzIjp7InRleHRTZWFyY2hJbnB1dHMiOlsiZm9yZCBlZGdlIHRpdGFuaXVtIl19LCJmaWx0ZXJTb3VyY2UiOjExfQ%3D%3D 2. Unable to find the car images. Could we please get the CL [mentioned in the description] reverted on the M72 branch by 1/17 as M72 has stable cut next week.
,
Jan 18
(4 days ago)
Friendly ping to get an update as per C#8 as it is marked as RB stable. Thanks..!
,
Yesterday
(27 hours ago)
As this is Blink, tentatively applying Android, Chrome OS, Linux and Mac as well. + candrada@ & kgnaidu@, requesting to repro on live M72 beta build #72.0.3626.64 on Android. Reminder M72 Stable is coming soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Yesterday
(27 hours ago)
,
Today
(12 hours ago)
ramine@, can you please check on Android? Thanks.
,
Today
(11 hours ago)
The issue is that I forgot to take into account the semantics of inclusive intersection in my previous CL, which fixed a problem in which we would report offscreen elements as onscreen if they were contained by an effect. The fix for the current issue should be simple.
,
Today
(10 hours ago)
Bug is repro on chrome Beta 72.0.3626.64 and not repro on chrome stable 71.0.3578.99 Android releases.
,
Today
(8 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3516e4de22fc07696b04e22de5d07bad49778395 commit 3516e4de22fc07696b04e22de5d07bad49778395 Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Jan 22 21:45:31 2019 [PE] Fix inclusive intersection + effects We should use the result of InclusiveIntersect rather than IsEmpty, to handle the case of a zero-area intersection when the source element has zero height or width. Bug: 920674 Change-Id: Ib71a4b1675afbfaf7a6c4ef3e1c39598e610620e Reviewed-on: https://chromium-review.googlesource.com/c/1427559 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#624936} [modify] https://crrev.com/3516e4de22fc07696b04e22de5d07bad49778395/third_party/blink/renderer/platform/graphics/paint/geometry_mapper.cc [modify] https://crrev.com/3516e4de22fc07696b04e22de5d07bad49778395/third_party/blink/renderer/platform/graphics/paint/geometry_mapper_test.cc
,
Today
(8 hours ago)
Pls update bug with canary result on Thursday morning. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Jan 10