New issue
Advanced search Search tips

Issue 920654 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Misleading "success" message on failure with upload_to_google_storage.py

Project Member Reported by mbarow...@chromium.org, Jan 10

Issue description

When uploading a wprgo file to the chrome-partner-telemetry bucket, I accidentally gave the wrong path. The upload_to_google_storage.py script printed out that it was skipping the file, but then computed a hash anyway and output the message "Success!"

This made me think the first error message was wrong or the operation had somehow been retried. 
 
Labels: -Pri-2 Pri-3
I don't understand the failure condition, can you clarify?  

What do you mean "wrong path"? Like a path that exist but wasn't your intended file? A file that has uploaded before?  This kind of sounds WAI.

Going forward though, we now recommend using CIPD for binary packages since it has better versioning (tags!), security (real acls!), and performance (downloads are supported natively in gclient, with parallel downloads).
An invalid path: no file exists there. The file had not been previously uploaded. 

If upload_to_google_storage.py is no longer the recommended script, what should the documentation here suggest? https://sites.google.com/a/chromium.org/dev/developers/telemetry/record_a_page_set
I don't know, I don't manage telemetry, but it looks like switching to cipd is on the radar: 782391
Labels: -Pri-3 Pri-2
Owner: crouleau@chromium.org
Status: Assigned (was: Available)
Hey, I will look into this.

Note that this is from the discussion: https://groups.google.com/a/google.com/forum/?utm_medium=email&utm_source=footer#!msg/chrome-benchmarking/cyJHxtAemLY/AlgyorxmAgAJ

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment