New issue
Advanced search Search tips

Issue 920641 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

UrlBarTest#testFocusingOnStartup failing on chromium.memory/Android CFI

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 10

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of adithyas@google.com

chrome_public_test_apk failing on chromium.memory/Android CFI

Builders failed on: 
- Android CFI: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI


 
Owner: tedc...@chromium.org
Status: Assigned (was: Available)
+tedchoc@ who is the directory owner.

Stack trace from logs:

java.lang.UnsatisfiedLinkError: No implementation found for long org.chromium.base.metrics.RecordHistogram.nativeRecordEnumeratedHistogram(java.lang.String, long, int, int) (tried Java_org_chromium_base_metrics_RecordHistogram_nativeRecordEnumeratedHistogram and Java_org_chromium_base_metrics_RecordHistogram_nativeRecordEnumeratedHistogram__Ljava_lang_String_2JII)
	at org.chromium.base.metrics.RecordHistogram.nativeRecordEnumeratedHistogram(RecordHistogram.java)
	at org.chromium.base.metrics.RecordHistogram.recordEnumeratedHistogram(RecordHistogram.java:84)
	at org.chromium.chrome.browser.metrics.OmniboxStartupMetrics.maybeRecordHistograms(OmniboxStartupMetrics.java:142)
	at org.chromium.chrome.browser.toolbar.ToolbarManager.destroy(ToolbarManager.java:1153)
	at org.chromium.chrome.browser.ChromeActivity.onDestroy(ChromeActivity.java:1319)
	at android.app.Activity.performDestroy(Activity.java:6422)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1142)
	at android.support.test.runner.MonitoringInstrumentation.callActivityOnDestroy(MonitoringInstrumentation.java:519)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3818)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:3849)
	at android.app.ActivityThread.-wrap5(ActivityThread.java)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1398)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5417)
	at java.lang.reflect.Method.invoke(Method.java)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Reading Android symbols from: /b/swarming/w/ir
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Release/lib.unstripped:/b/swarming/w/ir/out/Release
Searching for native crashes in: /b/swarming/w/itN4gzOr/tmp4ucd6a
Unknown Android release, consider passing --packed-lib.
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Release/lib.unstripped:/b/swarming/w/ir/out/Release
Cc: -adithyas@google.com adithyas@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca578643994678e047bdcdfe1f63fd3548afc04

commit dca578643994678e047bdcdfe1f63fd3548afc04
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Jan 10 18:18:40 2019

Disable UrlBarTest#testFocusingOnStartup

No-Try: true
Tbr: tedchoc@chromium.org
Bug:  920641 
Change-Id: Ia738abb75283fc141552b6b3281525a541da31a3
Reviewed-on: https://chromium-review.googlesource.com/c/1405429
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621644}
[modify] https://crrev.com/dca578643994678e047bdcdfe1f63fd3548afc04/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java

Labels: -Sheriff-Chromium
Test disabled, removing sheriff label.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da82c7fe85b3d6b356e64b95557b1a29f27ffda3

commit da82c7fe85b3d6b356e64b95557b1a29f27ffda3
Author: Ted Choc <tedchoc@chromium.org>
Date: Thu Jan 10 20:38:47 2019

Fix crash in logging omnibox metrics before native.

If we destroy the activity before initializing native, then
we will crash attempting to log omnibox metrics.  Ideally, we'd
have a way to robustly record metrics before native, but that
doesn't exist yet.

This just prevents the crash.

BUG= 920641 

Change-Id: Iebdada4f51034caa89c243ffa22c2ae55d4cbb29
Reviewed-on: https://chromium-review.googlesource.com/c/1405495
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621732}
[modify] https://crrev.com/da82c7fe85b3d6b356e64b95557b1a29f27ffda3/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/da82c7fe85b3d6b356e64b95557b1a29f27ffda3/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment