New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 920636 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: false

Project Member Reported by ClusterFuzz, Jan 10

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5161318025527296

Fuzzer: libFuzzer_pdfium_fuzzer
Fuzz target binary: pdfium_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  false
  CPDF_Font::GetAdobeCharName
  CPDF_CIDFont::GlyphFromCharCode
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=402692:402822

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5161318025527296

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.
 
Project Member

Comment 1 by ClusterFuzz, Jan 10

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 10

Cc: tsepez@chromium.org dsinclair@chromium.org jochen@chromium.org caryclark@google.com npm@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jan 10

Labels: Test-Predator-Auto-Owner
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/8ea3f5176aab4d6688710d9937cf38a43c14d030 (Clean up some CPDF_Font subclasses.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/caf2cd67df8434371061791ab7fde0d50fe909c2

commit caf2cd67df8434371061791ab7fde0d50fe909c2
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Jan 11 19:18:04 2019

Remove a NOTREACHED() in CPDF_Font::GetAdobeCharName().

It is reachable. Add a unit test to exercise this code path.

BUG= chromium:920636 

Change-Id: I57c9102fe215ae48fc46d496bae4efc399629e0b
Reviewed-on: https://pdfium-review.googlesource.com/c/48134
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/caf2cd67df8434371061791ab7fde0d50fe909c2/core/fpdfapi/font/BUILD.gn
[add] https://crrev.com/caf2cd67df8434371061791ab7fde0d50fe909c2/core/fpdfapi/font/cpdf_cidfont_unittest.cpp
[modify] https://crrev.com/caf2cd67df8434371061791ab7fde0d50fe909c2/core/fpdfapi/font/cpdf_font.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39cb8139cc89b1b2e73ae258157398daa9ba9b73

commit 39cb8139cc89b1b2e73ae258157398daa9ba9b73
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 11 20:48:14 2019

Roll src/third_party/pdfium ef92f656a86e..caf2cd67df84 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/ef92f656a86e..caf2cd67df84


git log ef92f656a86e..caf2cd67df84 --date=short --no-merges --format='%ad %ae %s'
2019-01-11 thestig@chromium.org Remove a NOTREACHED() in CPDF_Font::GetAdobeCharName().


Created with:
  gclient setdep -r src/third_party/pdfium@caf2cd67df84

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:920636 
TBR=dsinclair@chromium.org

Change-Id: I3f07671a4a213fa1d50c7b6d5f568a53d57db0a7
Reviewed-on: https://chromium-review.googlesource.com/c/1407100
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#622137}
[modify] https://crrev.com/39cb8139cc89b1b2e73ae258157398daa9ba9b73/DEPS

Project Member

Comment 7 by ClusterFuzz, Jan 12

ClusterFuzz has detected this issue as fixed in range 622136:622137.

Detailed report: https://clusterfuzz.com/testcase?key=5161318025527296

Fuzzer: libFuzzer_pdfium_fuzzer
Fuzz target binary: pdfium_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  false
  CPDF_Font::GetAdobeCharName
  CPDF_CIDFont::GlyphFromCharCode
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=402692:402822
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=622136:622137

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5161318025527296

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jan 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5161318025527296 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment