New issue
Advanced search Search tips

Issue 920632 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: 14
NextAction: 2019-01-21
OS: ----
Pri: 1
Type: Feature


Participants' hotlists:
Sheriff-RotaNG


Sign in to add a comment

Don't schedule shifts on weekends

Project Member Reported by lfg@chromium.org, Jan 10

Issue description

The stability sheriff rotation uses 2 day shifts which do not span the weekends, so a shift scheduled for Friday should be split into 2 one-day shifts (Friday and Monday). The same is true for the Chrome build sheriff tree.

The old rotation.py script used to do this, but it is not currently supported by rota-ng.

 
Owner: olakar@chromium.org
Thx. for filing this request. 

I'll give this a go next week. 
Cc: olivierrobin@chromium.org
Same issue for the "chrome ios build sheriff" and "bling piper" rotations

Comment 4 by olakar@chromium.org, Jan 16 (6 days ago)

EstimatedDays: 14
NextAction: 2019-01-21
I'll work to get this put in next week.

Comment 5 by olakar@chromium.org, Jan 21 (2 days ago)

Components: -Infra>Sheriffing>Rotations Infra>ProdTech>Rotation
Labels: -Pri-2 Pri-1
Moving to the new home for RotaNG and rotations.

Also upping the prio to 1.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 21 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cca81280586bcfeb13f1e41e6f698643c7940a45

commit cca81280586bcfeb13f1e41e6f698643c7940a45
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon Jan 21 04:38:38 2019

[rotang] Shift modifier for avoiding weekends.

- Add an interface for shift Modifiers.
  These are used to modify generated shifts.
  Want this to be expandable, already have a feature request to add
  the ability to avoid public holidays.
- Implements a modifier to have shifts avoid weekends.
  As requested in bug crbug/920632.
- Add in the basics to handle non MTV timezones for rotations.

  The UI part and usage will come in later CL.

Bug: 920632
Change-Id: I0313ce0a92f47399bfaa5fcacd9dd8c7afda357c
Reviewed-on: https://chromium-review.googlesource.com/c/1424522
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Scott Lewis-Kelly <slewiskelly@google.com>
Cr-Commit-Position: refs/heads/master@{#20095}
[modify] https://crrev.com/cca81280586bcfeb13f1e41e6f698643c7940a45/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/cca81280586bcfeb13f1e41e6f698643c7940a45/go/src/infra/appengine/rotang/pkg/algo/algo.go
[add] https://crrev.com/cca81280586bcfeb13f1e41e6f698643c7940a45/go/src/infra/appengine/rotang/pkg/algo/weekendskip_test.go
[add] https://crrev.com/cca81280586bcfeb13f1e41e6f698643c7940a45/go/src/infra/appengine/rotang/pkg/algo/weekendskip.go

Comment 7 by olakar@chromium.org, Jan 21 (2 days ago)

The basics are in.

Next up is to get a UI to enable the new option.

Comment 8 by monor...@bugs.chromium.org, Yesterday (42 hours ago)

The NextAction date has arrived: 2019-01-21

Comment 9 by olakar@chromium.org, Today (108 minutes ago)

https://chromium-review.googlesource.com/c/infra/infra/+/1428639 out for review. 

It's pushed to the staging environment. 

https://rota-ng-staging.googleplex.com

The Shifts management and Config Create/Modify now have checkboxes for shift modifiers.

Sign in to add a comment