Experiment to reverse tab switch logic |
|
Issue descriptionFeature description: This experiment reverses the tabs switch button logic. That is, clicking it will navigate locally, while selecting the suggestion will switch tabs. The experiment's purpose is to find out if that behavior is too surprising. Eng owner: krb Product owner: emilyschechter Design doc: none, simple experiment Are you planning on experimenting before launch? Any new strings? Any implications for Google webservices (i.e. sync, translate)? Binary size? Do the existing perf tests exercise all aspects of your new feature(s)?
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e37ec875962eb36dae02c5d73e5fdde01630ac0b commit e37ec875962eb36dae02c5d73e5fdde01630ac0b Author: Kevin Bailey <krb@chromium.org> Date: Wed Jan 16 00:41:53 2019 [omnibox] Reverse the logic of the tab switch button on flag This CL represents an experiment to see what flipping the logic of the tab switch button would do. That is, selecting the suggestion will switch tabs, while clicking the button (which now says, "Open in this tab") will navigate locally. Bug: 920628 Change-Id: Ib748340f940f03d003a82a1eabb43b968529b0a2 Reviewed-on: https://chromium-review.googlesource.com/c/1405172 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#622940} [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/components/omnibox/browser/autocomplete_match_type.cc [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/components/omnibox/browser/autocomplete_match_type.h [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/e37ec875962eb36dae02c5d73e5fdde01630ac0b/components/omnibox/browser/omnibox_field_trial.h |
|
►
Sign in to add a comment |
|
Comment 1 by benhenry@google.com
, Jan 11