benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.v8.runtime_stats.top_25 is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyewsSBUZsYWtlInBjaHJvbWl1bUB0ZWxlbWV0cnlfcGVyZl91bml0dGVzdHNAYmVuY2htYXJrcy5iZW5jaG1hcmtfc21va2VfdW5pdHRlc3QuQmVuY2htYXJrU21va2VUZXN0LnY4LnJ1bnRpbWVfc3RhdHMudG9wXzI1DA. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%3A%20benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.v8.runtime_stats.top_25&comment=Link%20to%20flake%20details%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyewsSBUZsYWtlInBjaHJvbWl1bUB0ZWxlbWV0cnlfcGVyZl91bml0dGVzdHNAYmVuY2htYXJrcy5iZW5jaG1hcmtfc21va2VfdW5pdHRlc3QuQmVuY2htYXJrU21va2VUZXN0LnY4LnJ1bnRpbWVfc3RhdHMudG9wXzI1DA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Crashing Stack Trace: 005ae3a4 65fa6dc5 68d51a58 000004f0 06df0115 chrome_child!base::debug::BreakDebugger+0xc 005ae3c4 65a7a23b 01179028 68d51a58 000004f0 chrome_child!?Run@?$Invoker@U?$BindState@P6AXPBDHV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@base@@1@Z$$V@internal@base@@$$A6AXPBDHV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@3@1@Z@internal@base@@SAXPAVBindStateBase@23@PBDH$$QAV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@3@2@Z+0x1f 005ae8f0 65ae0626 094a1878 69770a38 06e09498 chrome_child!logging::LogMessage::~LogMessage+0x45b 005aea1c 65ae28db 005aea58 00000049 69724c9c chrome_child!base::trace_event::TraceLog::AddTraceEventWithThreadIdAndTimestamp+0x116 005aea78 67b09891 00000049 69724c9c 694d8906 chrome_child!trace_event_internal::AddTraceEventWithThreadIdAndTimestamp+0x6b 005aeb84 67b098e9 06de0868 507c6b40 06dca2a0 chrome_child!blink::ImagePaintTimingDetector::OnLastImagePaintDetected+0xfb 005aeb98 67b09d47 00000023 00000000 005aec84 chrome_child!blink::ImagePaintTimingDetector::Analyze+0x49 005aec70 67b0a695 00000001 00000000 83a84c87 chrome_child!blink::ImagePaintTimingDetector::ReportSwapTime+0xe1 005aec94 6576947e 06ddd218 00000000 005aecb0 chrome_child!base::internal::Invoker<base::internal::BindState<void (__thiscall blink::ImagePaintTimingDetector::*)(unsigned int,enum blink::WebLayerTreeView::SwapResult,base::TimeTicks),blink::WeakPersistent<blink::ImagePaintTimingDetector>,unsigned int>,void __cdecl(enum blink::WebLayerTreeView::SwapResult,base::TimeTicks)>::RunOnce+0x2d 005aeccc 67b0a650 00000000 83a84c87 00000002 chrome_child!base::OnceCallback<void __cdecl(enum blink::WebLayerTreeView::SwapResult,base::TimeTicks)>::Run+0x46 005aedb0 67b0a7c1 00000000 83a84c87 00000002 chrome_child!WTF::ThreadCheckingCallbackWrapper<base::OnceCallback<void __cdecl(enum blink::WebLayerTreeView::SwapResult,base::TimeTicks)>,void __cdecl(enum blink::WebLayerTreeView::SwapResult,base::TimeTicks)>::Run+0x6e 005aedc4 6576947e 06dbfd78 00000000 005aede0 chrome_child!base::internal::Invoker<base::internal::BindState<void (__thiscall media::internal::TrampolineHelper<base::RepeatingCallback<void __cdecl(scoped_refptr<media::VideoFrame> const &,base::TimeTicks)> >::*)(scoped_refptr<media::VideoFrame> const &,base::TimeTicks),std::unique_ptr<media::internal::TrampolineHelper<base::RepeatingCallback<void __cdecl(scoped_refptr<media::VideoFrame> const &,base::TimeTicks)> >,std::default_delete<media::internal::TrampolineHelper<base::RepeatingCallback<void __cdecl(scoped_refptr<media::VideoFrame> const &,base::TimeTicks)> > > > >,void __cdecl(scoped_refptr<media::VideoFrame> const &,base::TimeTicks)>::Run+0x17 005aedfc 669d89e0 00000000 83a84c87 00000002 chrome_child!base::OnceCallback<void __cdecl(enum blink::WebLayerTreeView::SwapResult,base::TimeTicks)>::Run+0x46 005aee30 669d89a6 83a84c87 00000002 00000000 chrome_child!base::internal::VectorBuffer<std::pair<unsigned int,std::vector<base::OnceCallback<void __cdecl(base::TimeTicks)>,std::allocator<base::OnceCallback<void __cdecl(base::TimeTicks)> > > > >::MoveRange<std::pair<unsigned int,std::vector<base::OnceCallback<void __cdecl(base::TimeTicks)>,std::allocator<base::OnceCallback<void __cdecl(base::TimeTicks)> > > >,0>+0x452 005aee64 669d8946 06df773c 06df7734 06df7730 chrome_child!base::internal::VectorBuffer<std::pair<unsigned int,std::vector<base::OnceCallback<void __cdecl(base::TimeTicks)>,std::allocator<base::OnceCallback<void __cdecl(base::TimeTicks)> > > > >::MoveRange<std::pair<unsigned int,std::vector<base::OnceCallback<void __cdecl(base::TimeTicks)>,std::allocator<base::OnceCallback<void __cdecl(base::TimeTicks)> > > >,0>+0x418 005aee84 66a4fa91 06df7718 68dcd76a 65aca06d chrome_child!base::internal::VectorBuffer<std::pair<unsigned int,std::vector<base::OnceCallback<void __cdecl(base::TimeTicks)>,std::allocator<base::OnceCallback<void __cdecl(base::TimeTicks)> > > > >::MoveRange<std::pair<unsigned int,std::vector<base::OnceCallback<void __cdecl(base::TimeTicks)>,std::allocator<base::OnceCallback<void __cdecl(base::TimeTicks)> > > >,0>+0x3b8 005aef98 660ebec4 68ed140a 005aeff0 01b62580 chrome_child!base::debug::TaskAnnotator::RunTask+0x121 005af108 660ebcbd 00000000 0117f110 005af134 chrome_child!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl+0x204 005af118 660d96c7 0117f120 0117f118 01b62580 chrome_child!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork+0x1d 005af134 660ec687 01b62584 00000100 69724e94 chrome_child!base::MessagePumpDefault::Run+0x87 005af20c 65a9ddba 00000001 00000000 65b0172f chrome_child!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run+0x97 005af318 6608e8c8 005af420 01178200 01b62c6c chrome_child!base::RunLoop::Run+0x2aa 005af3fc 65a58aaf 005af42c 0117b618 005af4f8 chrome_child!content::RendererMain+0x3a0 005af414 65a59139 005af4f8 005af42c 005af6ac chrome_child!content::RunOtherNamedProcessTypeMain+0x4b 005af528 65a58833 00000000 005af644 005af634 chrome_child!content::ContentMainRunnerImpl::Run+0x1b5 005af538 65a5c982 772b3406 ffffffff 00000000 chrome_child!content::ContentServiceManagerMainDelegate::RunEmbedderProcess+0x13 005af634 65a58a3b 005af640 005af644 68d45990 chrome_child!service_manager::Main+0x372 005af674 638c1120 005af698 005af680 005af67c chrome_child!content::ContentMain+0x33
Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1380193
It's likely due to my change. Looking.
Fix in flight https://chromium-review.googlesource.com/c/chromium/src/+/1407088
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cbb8929dda7111cee9f99d5e36398b9310319e9 commit 4cbb8929dda7111cee9f99d5e36398b9310319e9 Author: Liquan(Max) Gu <maxlg@chromium.org> Date: Fri Jan 11 19:56:51 2019 [FCP++] Prevent null from being trace time We introduced a bug in https://chromium-review.googlesource.com/c/chromium/src/+/1380193. When image paint detector finds the largest paint candidate with null time, it passes in to the trace, which will cause a crash. To fix it, we skip the candidate if the candidate's time is null. Bug: 920627 Change-Id: Ie39ac9fbc1d09fc88e09851497a80610969bd527 Reviewed-on: https://chromium-review.googlesource.com/c/1407088 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622112} [modify] https://crrev.com/4cbb8929dda7111cee9f99d5e36398b9310319e9/third_party/blink/renderer/core/paint/image_paint_timing_detector.cc [modify] https://crrev.com/4cbb8929dda7111cee9f99d5e36398b9310319e9/third_party/blink/renderer/core/paint/image_paint_timing_detector_test.cc [modify] https://crrev.com/4cbb8929dda7111cee9f99d5e36398b9310319e9/third_party/blink/renderer/core/paint/text_paint_timing_detector.cc
Comment 1 by cbruni@chromium.org
, Jan 11