Reworking of auth in buildbucket plugin broke binary-size plugin |
||
Issue descriptionGo to https://webrtc-review.googlesource.com/c/src/+/116683/6 and open console binary-size-view.js:215 Buildbucket search failed TypeError: this.$.client.getOAuthToken is not a function at HTMLElement._getBuilds (binary-size-view.js:192) at HTMLElement._tryGetNewBinarySizeInfo (binary-size-view.js:140) at HTMLElement._refresh (binary-size-view.js:112) at HTMLElement.reload (binary-size-view.js:81) https://chromium.googlesource.com/infra/gerrit-plugins/binary-size/+/2a20483/static/binary-size-view.js#192 Root cause: https://bugs.chromium.org/p/gerrit/issues/detail?id=9164#c31 removed the mentioned function.
,
Jan 10
Thanks, I'll check. But I fully expected that the refactoring was enough of a paradigm shift that it would also require some refactoring the binary-size plugin
,
Jan 10
my goal was to avoid breakages like this by providing a compatibility layer, but I missed this function, sorry since it is already broken, perhaps it would be better to update the binary-sizes plugin instead because it would be less tech debt overall? the new function is `window.buildbucket.getAccessToken()`. It returns a promise. Note that `window.buildbucket` does not exist until buildbucket plugin is loaded.
,
Jan 10
Yeah I can work on this now. Thanks for helping.
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/binary-size/+/248122bf4166617cc22a82e093d62b6fa78f5a9a commit 248122bf4166617cc22a82e093d62b6fa78f5a9a Author: Oleh Prypin <oprypin@webrtc.org> Date: Thu Jan 10 17:38:41 2019 Update for compatibility with changes in Buildbucket plugin https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/ab3014c..b1dd8c8/src/main/resources/static/cr-buildbucket-view.js Bug: chromium:920606 Change-Id: I8d65e1b07f1091ea18bf229c3e9a4c736776a7e9 [modify] https://crrev.com/248122bf4166617cc22a82e093d62b6fa78f5a9a/static/binary-size-view.js [modify] https://crrev.com/248122bf4166617cc22a82e093d62b6fa78f5a9a/test/binary-size-view_test.html
,
Jan 18
(4 days ago)
The release came through recently. |
||
►
Sign in to add a comment |
||
Comment 1 by no...@chromium.org
, Jan 10