New issue
Advanced search Search tips

Issue 920589 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

memory leak in video_capture_device_android.cc

Reported by daniel.c...@gmail.com, Jan 10

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce the problem:
std::unique_ptr<uint8_t> buffer(new uint8_t[buffer_length]);
should be
std::unique_ptr<uint8_t[]> buffer(new uint8_t[buffer_length]);

location:
https://cs.chromium.org/chromium/src/media/capture/video/android/video_capture_device_android.cc?q=video_capture_device_android.cc&sq=package:chromium&g=0&l=339

What is the expected behavior?
no memory leak

What went wrong?
a memory leak

Did this work before? No 

Chrome version: 71.0.3578.0  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 32.0 r0
 
Components: Blink>GetUserMedia>Webcam Internals>Media>Capture
Labels: -OS-Windows -Pri-2 OS-Android Pri-1
Labels: Needs-triage-Mobile
Cc: chelamcherla@chromium.org
Labels: -Needs-triage-Mobile
This doesn't seems to be triagable from TE team, Could someone from Internals>Media>Capture team please help in triaging this further.

Thanks!
Owner: tmathmeyer@chromium.org
Status: Assigned (was: Unconfirmed)
tmathmeyer@ for routing. Hi Ted, I'm David. I'll be helping out on Video Stack (Internals>Media>) bug routing. Please reach out to me if you have some feedback. Thanks! (Load balancing gpu issues between you sandersd@, liberato@ who have a lot) :) 
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61f4a44a36cbc1b4c36f963b05f646700cba46a1

commit 61f4a44a36cbc1b4c36f963b05f646700cba46a1
Author: Ted Meyer <tmathmeyer@chromium.org>
Date: Thu Jan 17 01:15:08 2019

Remove unused fields from PipelineInfo

audio_codec_name and origin_url were unused, and have been removed.

Bug: 920589
Change-Id: Ie107259894c11391c4babb8c0e7e379f7476f2fa
Reviewed-on: https://chromium-review.googlesource.com/c/1415693
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623494}
[modify] https://crrev.com/61f4a44a36cbc1b4c36f963b05f646700cba46a1/content/browser/media/media_internals.cc

Sign in to add a comment