Issue metadata
Sign in to add a comment
|
PermissionBubbleKioskBrowserTest.KioskHasNoLocationBar is flaky |
||||||||||||||||||
Issue descriptionFindit identified the culprit r619483 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vN2VlZDQ2MjQwMGFkYzc0NzhkMzM3NzYxOTAxMDRhZDU5NTg3OTkwNQw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r619483&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vN2VlZDQ2MjQwMGFkYzc0NzhkMzM3NzYxOTAxMDRhZDU5NTg3OTkwNQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Jan 10
Hey Aran, could your CL be the cause?
,
Jan 10
,
Jan 10
Do you mean https://crrev.com/c/1396130? What makes you suspect that CL?
,
Jan 11
Sorry, my mistake.
,
Jan 11
I'm gonna disable it on mac. Wei, could you please take a look?
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d26b18645a638bb2d0fd72b3716136c550b420e7 commit d26b18645a638bb2d0fd72b3716136c550b420e7 Author: Roman Sorokin <rsorokin@chromium.org> Date: Fri Jan 11 16:46:18 2019 [Sheriff] Disable PermissionBubbleKioskBrowserTest.KioskHasNoLocationBar Due to flakiness (see bug) It runs on mac only TBR=rsesek@chromium.org Bug: 920582 Change-Id: I5006cdb12017f7bfb4455f2bbfaaa738f6ffab12 Reviewed-on: https://chromium-review.googlesource.com/c/1407006 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#622028} [modify] https://crrev.com/d26b18645a638bb2d0fd72b3716136c550b420e7/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
,
Jan 11
,
Jan 15
Note that Findit claims https://chromium-review.googlesource.com/c/chromium/src/+/1351874 was the source of the flakiness on this test. Does Kiosk mode use fullscreen? If so perhaps adding a ScopedFakeNSWindowFullscreen to the test (as in https://chromium-review.googlesource.com/c/chromium/src/+/1351874/6/chrome/browser/extensions/api/tabs/tabs_test.cc ) would eliminate the flakiness, although it sounds like this is a hacky solution. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by rsorokin@chromium.org
, Jan 10