New issue
Advanced search Search tips

Issue 920565 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Soundwave fails with error dowloading bugs with unicode in summary

Project Member Reported by perezju@chromium.org, Jan 10

Issue description

what the title says
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a24a725f7834c16b3628bfb63f349b3480bf9592

commit a24a725f7834c16b3628bfb63f349b3480bf9592
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Jan 11 10:23:02 2019

[soundwave] Allow unicode in bug descriptions

When issues include special unicode chars in the description, they
couldn't be parsed by python's str. Change the type of this column to
allow for arbitrary unicode text.

Bug:  chromium:920565 
Change-Id: I78b4cf6fe34c454868d2decb8e9b1d8b2b21f995
Reviewed-on: https://chromium-review.googlesource.com/c/1404268
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/a24a725f7834c16b3628bfb63f349b3480bf9592/experimental/soundwave/soundwave/tables/bugs.py
[modify] https://crrev.com/a24a725f7834c16b3628bfb63f349b3480bf9592/experimental/soundwave/soundwave/tables/bugs_test.py
[modify] https://crrev.com/a24a725f7834c16b3628bfb63f349b3480bf9592/experimental/soundwave/bin/export_csv

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ba5360721c32abb11bf570e6963c8f3595a3894

commit 5ba5360721c32abb11bf570e6963c8f3595a3894
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 11 11:38:14 2019

Roll src/third_party/catapult 0df132fe0a47..a24a725f7834 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/0df132fe0a47..a24a725f7834


git log 0df132fe0a47..a24a725f7834 --date=short --no-merges --format='%ad %ae %s'
2019-01-11 perezju@chromium.org [soundwave] Allow unicode in bug descriptions


Created with:
  gclient setdep -r src/third_party/catapult@a24a725f7834

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:920565 
TBR=sullivan@chromium.org

Change-Id: I9916f54c1dcdcad09b4e1d493e14b179930e60f7
Reviewed-on: https://chromium-review.googlesource.com/c/1405818
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#621975}
[modify] https://crrev.com/5ba5360721c32abb11bf570e6963c8f3595a3894/DEPS

Sign in to add a comment