New issue
Advanced search Search tips

Issue 920563 link

Starred by 2 users
Status: Started
Owner:
lgrey@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Radio buttons appears blue in color even when not selected.

Project Member Reported by aim...@virtusa.com, Jan 10 
Chrome Version:  73.0.3667.0 (Official Build) e908663b57104ae7163ae941e16549e2a8ad65f5-refs/branch-heads/3667@{#1}(32/64-bit).
 	
OS: Win(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3) and Linux(14.04 LTS).
	       
What steps will reproduce the problem?
1. Launch chrome and Open NTP.
2. Click on Microphone icon on NTP and click on Block in permission Bubble. 
3. Click on 'Blocked Microphone Icon' in omnibox and observe the radio button in bubble. 

Actual Result: Radio buttons appears blue in color even when not selected.
Expected Result: Radio buttons should not appear blue in color when not selected.

This is a regression issue broken in M-73 and will soon update other info:
Good Build : 73.0.3666.0(Revision:620998)
Bad Build : 73.0.3667.0(Revision:621406)

Note:
Issue is observed for all radio button and check boxes.

Kindly refer the screen cast for reference

Thank You!
Actual Result.mp4
297 KB View Download
Expected Result.mp4
234 KB View Download

Comment 1 by aim...@virtusa.com, Jan 10

Labels: hasbisect-per-revision
Owner: lgrey@chromium.org
Status: Assigned (was: Unconfirmed)
Update:


You are probably looking for a change made after 621390 (known good), but no later than 621391 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/64f9fa5153f9e73ca45193e54a01fa077e59131f..c301f0abb8821646d3acea02aa73425360157d86

Suspect: https://chromium.googlesource.com/chromium/src/+/c301f0abb8821646d3acea02aa73425360157d86

lgrey: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!

Comment 2 by lgrey@chromium.org, Jan 10

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96aebe13839f36618bf49171f7c93b5e021a1b26

commit 96aebe13839f36618bf49171f7c93b5e021a1b26
Author: Leonard Grey <lgrey@chromium.org>
Date: Thu Jan 10 19:52:34 2019

Fix unselected checkbox/radio color

Looks like this also wasn't updated to MD2, and was recently "broken"
(in that it is currently a different color entirely, rather than the
wrong grey) by https://chromium-review.googlesource.com/c/chromium/src/+/1399044

Bug: 920563
Change-Id: I4384aee2494f48503f71df2ef6abc2e055206dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1405270
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621715}
[modify] https://crrev.com/96aebe13839f36618bf49171f7c93b5e021a1b26/ui/views/controls/button/checkbox.cc

Comment 4 by aim...@virtusa.com, Jan 11

Labels: TE-Verified-M73 TE-Verified-73.0.3668.0
Update:

Retested the above issue on Win(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3) and Linux(14.04 LTS) OS using latest Canary and issue is fixed.

Now, Radio buttons does not appear blue in color when not selected.

Kindly find below attached screen-cast for reference.

Thank You!
Canary Behaviour.mp4
356 KB View Download

Comment 5 by robliao@chromium.org, Jan 17 (6 days ago)

Labels: Hotlist-DesktopUIConsider

Comment 6 by robliao@chromium.org, Jan 18 (5 days ago)

Labels: Group-Focus_or_Input
►

Sign in to add a comment