New issue
Advanced search Search tips

Issue 920550 link

Starred by 1 user
Status: Fixed
Owner:
johntlee@chromium.org
Closed: Jan 11
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression : Gap between ghost text and input field is observed to be more than expected.

Project Member Reported by sav...@virtusa.com, Jan 10 
Chrome Version : 73.0.3667.0 (Official Build) e908663b57104ae7163ae941e16549e2a8ad65f5-refs/branch-heads/3667@{#1} 32/64 bit
OS : Mac(10.13.6, 10.13.1, 10.14.3), Windows (7,8,10), Linux(14.04 LTS)

Precondition : Enable #site-settings flag from chrome://flags

What steps will reproduce the problem?
1. Launch chrome with above flag and navigate to chrome://settings/content/all
2. Observe the 'Search' input field.

Actual Result : Gap between ghost text and input field is observed to be more than expected.

Expected Result : Ghost text and input field should have adequate gap.

This is a regression issue broken in M-73 and below is the bisect information:
Good Build : 73.0.3638.0 (Revision : 615717)
Bad Build : 73.0.3639.0 (Revision : 616124)

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/d867c4377115e2c0841460145ca43b964f13d5dc..f02c0f1a29ee970e07a9ac0d3bd0bb478116b4aa

Suspect: https://chromium.googlesource.com/chromium/src/+/f02c0f1a29ee970e07a9ac0d3bd0bb478116b4aa

@johntlee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Able to reproduce issue in Dev build #73.0.3664.3

Thank you..!
Screenshots.png
22.4 KB View Download
Actual_Result.mov
2.9 MB View Download

Comment 1 by johntlee@chromium.org, Jan 10

Screenshot from 2019-01-10 12-39-19.png
7.3 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917bc5e7e502892e978ca83a61e264eec755d6c2

commit 917bc5e7e502892e978ca83a61e264eec755d6c2
Author: John Lee <johntlee@chromium.org>
Date: Fri Jan 11 01:44:27 2019

Settings WebUI: Fix alignment of search input on chrome://settings/content/all

Bug:  920550 
Change-Id: I7894af6a98d36cbf7788bd9c93a71e1e8ca42e92
Reviewed-on: https://chromium-review.googlesource.com/c/1405978
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621856}
[modify] https://crrev.com/917bc5e7e502892e978ca83a61e264eec755d6c2/chrome/browser/resources/settings/site_settings/all_sites.html

Comment 3 by johntlee@chromium.org, Jan 11

Status: Fixed (was: Assigned)

Comment 4 by sav...@virtusa.com, Jan 11

Labels: TE-Verified-M73 TE-Verified-73.0.3668.0
---------
Update :
---------
Verified above issue in latest Canary build #73.0.3668.0 on Mac(10.13.1, 10.13.6, 10.14.3), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Now proper gap is seen between ghost text and input field.

Kindly review an attached screen-cast for reference.

Thank you..!
Canary_behavior.mov
3.0 MB View Download
►

Sign in to add a comment