New issue
Advanced search Search tips

Issue 920544 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 920539
Owner:
Closed: Jan 10
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: SitePerProcessDebuggerExtensionApiTest.Debugger



Sign in to add a comment

SitePerProcessDebuggerExtensionApiTest.Debugger is flaky

Project Member Reported by Findit, Jan 10

Issue description

Status: Closed (was: Untriaged)
Reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1404161
Project Member

Comment 2 by Findit, Jan 10

Mergedinto: 920539
Status: Duplicate (was: Closed)
This flake has been identified as being introduced in r621445
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/377dadb7a95df94d3f1aa7ce4ef4b14069306464

commit 377dadb7a95df94d3f1aa7ce4ef4b14069306464
Author: Joey Arhar <jarhar@chromium.org>
Date: Thu Jan 10 21:44:21 2019

Reland "[DevTools] Prevent JSONReader::Read errors from invalid unicode points"

Relanding http://crrev.com/c/1399538
Reverted by http://crrev.com/c/1404161

The original test didn't wait for Network.enable to finish before making
a request and expected to see network events, which did work... when
network service wasn't turned on. With network service enabled,
Network.enable takes longer and needs to be awaited for.

browser_tests now passes with --enable-features=NetworkService

Bug:  824174 ,  920539 ,  920544 
Change-Id: I3458b08ccce34ec6df6d7c0c65b5b5225ab3debc
Reviewed-on: https://chromium-review.googlesource.com/c/1405848
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621741}
[modify] https://crrev.com/377dadb7a95df94d3f1aa7ce4ef4b14069306464/chrome/browser/extensions/api/debugger/debugger_api.cc
[modify] https://crrev.com/377dadb7a95df94d3f1aa7ce4ef4b14069306464/chrome/test/data/extensions/api_test/debugger/background.js
[add] https://crrev.com/377dadb7a95df94d3f1aa7ce4ef4b14069306464/chrome/test/data/extensions/api_test/debugger/invalid_char.html

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a82ca95e0862fc6e12f655982362c54c0d01e9d7

commit a82ca95e0862fc6e12f655982362c54c0d01e9d7
Author: Roman Sorokin [CET] <rsorokin@chromium.org>
Date: Fri Jan 11 15:11:32 2019

Revert "Reland "[DevTools] Prevent JSONReader::Read errors from invalid unicode points""

This reverts commit 377dadb7a95df94d3f1aa7ce4ef4b14069306464.

Reason for revert: breaks tests on windows (see https://bugs.chromium.org/p/chromium/issues/detail?id=920997)

Original change's description:
> Reland "[DevTools] Prevent JSONReader::Read errors from invalid unicode points"
> 
> Relanding http://crrev.com/c/1399538
> Reverted by http://crrev.com/c/1404161
> 
> The original test didn't wait for Network.enable to finish before making
> a request and expected to see network events, which did work... when
> network service wasn't turned on. With network service enabled,
> Network.enable takes longer and needs to be awaited for.
> 
> browser_tests now passes with --enable-features=NetworkService
> 
> Bug:  824174 ,  920539 ,  920544 
> Change-Id: I3458b08ccce34ec6df6d7c0c65b5b5225ab3debc
> Reviewed-on: https://chromium-review.googlesource.com/c/1405848
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Joey Arhar <jarhar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#621741}

TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,jarhar@chromium.org

Change-Id: I2bea5199e19b0eb93394a241a9ec7833848b6c00
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  824174 ,  920539 ,  920544 
Reviewed-on: https://chromium-review.googlesource.com/c/1406685
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622007}
[modify] https://crrev.com/a82ca95e0862fc6e12f655982362c54c0d01e9d7/chrome/browser/extensions/api/debugger/debugger_api.cc
[modify] https://crrev.com/a82ca95e0862fc6e12f655982362c54c0d01e9d7/chrome/test/data/extensions/api_test/debugger/background.js
[delete] https://crrev.com/2f6cbb3b62a89f96cc7a4dccf898215bcf27fb05/chrome/test/data/extensions/api_test/debugger/invalid_char.html

Sign in to add a comment