Issue metadata
Sign in to add a comment
|
DebuggerExtensionApiTest.Debugger is flaky |
||||||||||||||||||||||
Issue descriptionFindit identified the culprit r621445 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmY2MDBkMDQ0YTk3NTE5YmYwNTUxMmFmNTQ3M2UzZDQ4YzRmNjE1Ygw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r621445&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmY2MDBkMDQ0YTk3NTE5YmYwNTUxMmFmNTQ3M2UzZDQ4YzRmNjE1Ygw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Jan 10
,
Jan 10
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/377dadb7a95df94d3f1aa7ce4ef4b14069306464 commit 377dadb7a95df94d3f1aa7ce4ef4b14069306464 Author: Joey Arhar <jarhar@chromium.org> Date: Thu Jan 10 21:44:21 2019 Reland "[DevTools] Prevent JSONReader::Read errors from invalid unicode points" Relanding http://crrev.com/c/1399538 Reverted by http://crrev.com/c/1404161 The original test didn't wait for Network.enable to finish before making a request and expected to see network events, which did work... when network service wasn't turned on. With network service enabled, Network.enable takes longer and needs to be awaited for. browser_tests now passes with --enable-features=NetworkService Bug: 824174 , 920539 , 920544 Change-Id: I3458b08ccce34ec6df6d7c0c65b5b5225ab3debc Reviewed-on: https://chromium-review.googlesource.com/c/1405848 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#621741} [modify] https://crrev.com/377dadb7a95df94d3f1aa7ce4ef4b14069306464/chrome/browser/extensions/api/debugger/debugger_api.cc [modify] https://crrev.com/377dadb7a95df94d3f1aa7ce4ef4b14069306464/chrome/test/data/extensions/api_test/debugger/background.js [add] https://crrev.com/377dadb7a95df94d3f1aa7ce4ef4b14069306464/chrome/test/data/extensions/api_test/debugger/invalid_char.html
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a82ca95e0862fc6e12f655982362c54c0d01e9d7 commit a82ca95e0862fc6e12f655982362c54c0d01e9d7 Author: Roman Sorokin [CET] <rsorokin@chromium.org> Date: Fri Jan 11 15:11:32 2019 Revert "Reland "[DevTools] Prevent JSONReader::Read errors from invalid unicode points"" This reverts commit 377dadb7a95df94d3f1aa7ce4ef4b14069306464. Reason for revert: breaks tests on windows (see https://bugs.chromium.org/p/chromium/issues/detail?id=920997) Original change's description: > Reland "[DevTools] Prevent JSONReader::Read errors from invalid unicode points" > > Relanding http://crrev.com/c/1399538 > Reverted by http://crrev.com/c/1404161 > > The original test didn't wait for Network.enable to finish before making > a request and expected to see network events, which did work... when > network service wasn't turned on. With network service enabled, > Network.enable takes longer and needs to be awaited for. > > browser_tests now passes with --enable-features=NetworkService > > Bug: 824174 , 920539 , 920544 > Change-Id: I3458b08ccce34ec6df6d7c0c65b5b5225ab3debc > Reviewed-on: https://chromium-review.googlesource.com/c/1405848 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621741} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,jarhar@chromium.org Change-Id: I2bea5199e19b0eb93394a241a9ec7833848b6c00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824174 , 920539 , 920544 Reviewed-on: https://chromium-review.googlesource.com/c/1406685 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#622007} [modify] https://crrev.com/a82ca95e0862fc6e12f655982362c54c0d01e9d7/chrome/browser/extensions/api/debugger/debugger_api.cc [modify] https://crrev.com/a82ca95e0862fc6e12f655982362c54c0d01e9d7/chrome/test/data/extensions/api_test/debugger/background.js [delete] https://crrev.com/2f6cbb3b62a89f96cc7a4dccf898215bcf27fb05/chrome/test/data/extensions/api_test/debugger/invalid_char.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ljusten@chromium.org
, Jan 10Status: Assigned (was: Untriaged)