New issue
Advanced search Search tips

Issue 920537 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Jan 11
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unable to see 'Turn On' button on 'Turn On Sync' overlay while signing in to chrome

Project Member Reported by vineet...@virtusa.com, Jan 10 
Chrome Version:73.0.3667.0 (Official Build) Revision e908663b57104ae7163ae941e16549e2a8ad65f5-refs/branch-heads/3667@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
1.Launch chrome and Sign in to chrome with valid credentials.
2.Observe button on 'Turn On Sync' overlay.

Actual Result  : 'Turn On' button is not seen on 'Turn On Sync' overlay while signing in to chrome.
Expected Result: 'Turn On' button should be seen properly on 'Turn On Sync' overlay while signing in to chrome.

This is a regression issue, broken in 'M-73'and will soon provide bisect info,
Good Build:73.0.3666.0(Revision:620998)
Bad Build :73.0.3667.0(Revision:621406)

Note: Also 'Turn On sync' button is not seen on chrome://welcome page.
ActualVideo.mp4
405 KB View Download
ExpectedVideo.mp4
443 KB View Download

Comment 1 by vineet...@virtusa.com, Jan 10

Labels: hasbisect-per-revision OS-Mac
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)
Update:
Per revision bisect info,

You are probably looking for a change made after 621349 (known good), but no later than 621350 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/338cc933e27c8c67e0df5193a1a885179f72ae75..dcca5677255f71457ba3918db68f322c8e31c9de

Suspect: https://chromium.googlesource.com/chromium/src/+/dcca5677255f71457ba3918db68f322c8e31c9de

@dbeam: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue also seen on Mac OS.

Thank you

Comment 2 by nyerramilli@chromium.org, Jan 10

Cc: ligim...@chromium.org
Labels: ReleaseBlock-Dev
marking as RBD, please change if required

Comment 3 by dbeam@chromium.org, Jan 11

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cfb095f09183890455d45cd5695d67eda28d6a7

commit 4cfb095f09183890455d45cd5695d67eda28d6a7
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 11 05:51:01 2019

Dark Mode: fix accidentally removed dependency

Certain shades of our Google palette are only in shared_vars_css.html,
not in paper-styles/color.html

https://crrev.com/c/1399512 made that faulty assumption.

This broke buttons on many pages (i.e. welcome, sign in dialog, etc.)

TBR=dpapad@chromium.org
BUG=883049, 920540 , 920537 

Change-Id: I7b019f90007612fb020b33535b79410447ca8666
Reviewed-on: https://chromium-review.googlesource.com/c/1405724
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621921}
[modify] https://crrev.com/4cfb095f09183890455d45cd5695d67eda28d6a7/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 5 by dbeam@chromium.org, Jan 11

Status: Fixed (was: Started)
hopefully fixed

Comment 6 by vineet...@virtusa.com, Jan 17 (5 days ago)

Labels: TE-Verified-M73 TE-Verified-73.0.3673.0
Update:

Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3)OS using Dev build #73.0.3673.0 and the issue is fixed. Kindly refer attached screen cast.

Thank you
DevBehavior.mp4
1.0 MB View Download
►

Sign in to add a comment