New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 920521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

cros-camera-libcamera_timezone needs to DEPEND on cros-camera-libcamera_common

Project Member Reported by drinkcat@chromium.org, Jan 10

Issue description

https://logs.chromium.org/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8924747710122733376/+/steps/BuildPackages/0/stdout

I think the build would have passed if there wasn't any other breaking change, after a retry, but the dependency is still missing.

Steps to repro (I used BOARD=kukui)

# emerge-$BOARD -aC cros-camera-libcamera_common
# emerge-$BOARD -av cros-camera-libcamera_timezone

 
Labels: -Pri-2 Pri-0
Actually nothing in that build would have tried to build cros-camera-libcamera_common .

So this is breaking ToT. P0.
Cc: vapier@chromium.org nednguyen@chromium.org
Owner: hidehiko@chromium.org
Status: Started (was: Untriaged)
The root cause of the build failure is different.

The include files are whitelisted in the build environment, but the -I is set wrongly.

armv7a-cros-linux-gnueabihf-clang++ -MMD -MF obj/camera/common/libcamera_timezone.timezone.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iobj/camera/common/libcamera_timezone.gen/include -Igen/include -I/build/kevin/tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/cros-camera-libcamera_timezone-0.0.1 -I/build/kevin/tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/platform/arc-camera -I/build/kevin/tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/platform/arc-camera/include -I/build/kevin/usr/include -Wall -Wno-psabi -Wunused -Wno-unused-parameter -Wunreachable-code -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/kevin -Wno-unused-local-typedefs -DBASE_VER=456626 -pthread -I/build/kevin/usr/include/base-456626 -I/build/kevin/usr/include/glib-2.0 -I/build/kevin/usr/lib/glib-2.0/include -I/build/kevin/usr/include/nss -I/build/kevin/usr/include/nspr -I/build/kevin/usr/include/dbus-1.0 -I/build/kevin/usr/lib/dbus-1.0/include -fPIC -std=gnu++14 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -march=armv8-a+crc -mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../../../../../tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/cros-camera-libcamera_timezone-0.0.1/camera/common/timezone.cc -o obj/camera/common/libcamera_timezone.timezone.o
c

Specifically, it has

-I/build/kevin/tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/platform/arc-camera
-I/build/kevin/tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/platform/arc-camera/include

but they must be

-I/build/kevin/tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/platform2/camera
-I/build/kevin/tmp/portage/media-libs/cros-camera-libcamera_timezone-0.0.1-r127/work/platform2/camera/include

I'm not sure why it passed the prev CQ, though...
Anyway, fixing now.
The include path is defined in build/cros-camera-common.gypi. I guess in previous CQ the packages were built with difference order, so we passed by luck.
Yes and and the fix is here crrev.com/c/1404457.
The trybot is runnign now.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4f60316c28a4c9070d43f4dd2c092525fc530de9

commit 4f60316c28a4c9070d43f4dd2c092525fc530de9
Author: Nicolas Boichat <drinkcat@chromium.org>
Date: Thu Jan 10 08:59:28 2019

Revert "camera: Migrate platform/arc-camera into platform2/camera."

This reverts commit de31ebeb5809881aaf342115628e77520793fff5.

Reason for revert: Breaks ToT

Original change's description:
> camera: Migrate platform/arc-camera into platform2/camera.
> 
> BUG=chromium:803783
> TEST=Built locally.
> CQ-DEPEND=CL:1401888
> 
> Change-Id: I91b5c3eef0960bb27118ceeade11137dbf8fbe5a
> Reviewed-on: https://chromium-review.googlesource.com/1373669
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

BUG=chromium:803783
BUG= chromium:920521 

Change-Id: I9db666cb1a276dd41d2466d5499d4bf990295b70
Reviewed-on: https://chromium-review.googlesource.com/c/1404781
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/eclass/cros-camera.eclass
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/chromeos-base/cros-camera/cros-camera-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9b5b52cbc622a593c0b58c9e963d8feaee0f6274

commit 9b5b52cbc622a593c0b58c9e963d8feaee0f6274
Author: Nicolas Boichat <drinkcat@chromium.org>
Date: Thu Jan 10 08:59:35 2019

Revert "Update ebuild files for platform/arc-camera -> platform2/camera migration."

This reverts commit 67b4db085a4624e5f4dea2c06f0cd1765581b71f.

Reason for revert: Breaks ToT  crbug.com/920521 

Original change's description:
> Update ebuild files for platform/arc-camera -> platform2/camera migration.
> 
> BUG=chromium:803783
> TEST=Built locally.
> CQ-DEPEND=CL:1373669
> 
> Change-Id: I790f3821f331f5dced6302e64a08124cb094abc0
> Reviewed-on: https://chromium-review.googlesource.com/1401888
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>

BUG=chromium:803783
BUG= chromium:920521 

Change-Id: If3b18ea57b8b91376c75f525dcd0b7e875d17cf8
Reviewed-on: https://chromium-review.googlesource.com/c/1404876
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/9b5b52cbc622a593c0b58c9e963d8feaee0f6274/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/9b5b52cbc622a593c0b58c9e963d8feaee0f6274/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild

Status: Fixed (was: Started)
Marked as fixed since the tree got green, thanks to the revert done by drinkcat@.
The camera repository migration is tracked in crbug.com/803783.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d870b3e25a9ae800f8cb0a90bd172416f65ad01e

commit d870b3e25a9ae800f8cb0a90bd172416f65ad01e
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:43 2019

Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration."

This reverts commit 9b5b52cbc622a593c0b58c9e963d8feaee0f6274 with the fix.

The fix is additional CROS_WORKON_SUBTREE entry (camera/include).
The directory contains shared header files, which are accessed during
the build.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1404786

Change-Id: I6d0e3b953ff497649b102477527b1fad4751cff4
Reviewed-on: https://chromium-review.googlesource.com/1404882
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d870b3e25a9ae800f8cb0a90bd172416f65ad01e/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/d870b3e25a9ae800f8cb0a90bd172416f65ad01e/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/731531ca1e122e4849b47f540489b02915cad735

commit 731531ca1e122e4849b47f540489b02915cad735
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:43 2019

Reland "camera: Migrate platform/arc-camera into platform2/camera."

This reverts commit 4f60316c28a4c9070d43f4dd2c092525fc530de9 with the fix.

The fix is to add CROS_WORKON_SUBTREE entry (camera/include) to
arc-camera-service. The directory contains shared header files,
which are accessed during the build.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1404457, CL:1404882

Change-Id: Ic0203920336a52a4fd122779e010de8e8576471c
Reviewed-on: https://chromium-review.googlesource.com/1404786
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/eclass/cros-camera.eclass
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/chromeos-base/cros-camera/cros-camera-9999.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/612ae3f53c7c4a36fe983869dd050bbddb2ff7cb

commit 612ae3f53c7c4a36fe983869dd050bbddb2ff7cb
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:44 2019

camera: Fix src_root_path.

The repository is migrated into platform2/camera,
but the path was kept old.

BUG= chromium:920521 , chromium:803783
TEST=Ran try.
CQ-DEPEND=CL:1404786

Change-Id: Id26b1b71e844af22864783ab02222f033d7ca76f
Reviewed-on: https://chromium-review.googlesource.com/1404457
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/612ae3f53c7c4a36fe983869dd050bbddb2ff7cb/camera/build/cros-camera-common.gypi

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9fe2dec9926e921379764a798a1884e509df67c3

commit 9fe2dec9926e921379764a798a1884e509df67c3
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Jan 15 23:36:45 2019

Revert "camera: Fix src_root_path."

This reverts commit 612ae3f53c7c4a36fe983869dd050bbddb2ff7cb.

Reason for revert: non-deterministic builds

Original change's description:
> camera: Fix src_root_path.
> 
> The repository is migrated into platform2/camera,
> but the path was kept old.
> 
> BUG= chromium:920521 , chromium:803783
> TEST=Ran try.
> CQ-DEPEND=CL:1404786
> 
> Change-Id: Id26b1b71e844af22864783ab02222f033d7ca76f
> Reviewed-on: https://chromium-review.googlesource.com/1404457
> Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Bug:  chromium:920521 , chromium:803783
Change-Id: I70f9f52b59cae184e770c43cc46bd3c012cea336
Reviewed-on: https://chromium-review.googlesource.com/c/1413495
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/9fe2dec9926e921379764a798a1884e509df67c3/camera/build/cros-camera-common.gypi

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/fafb6a126a8b33364ab4731c9a901f172736cb22

commit fafb6a126a8b33364ab4731c9a901f172736cb22
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Jan 15 23:36:57 2019

Revert "Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration.""

This reverts commit d870b3e25a9ae800f8cb0a90bd172416f65ad01e.

Reason for revert: non-deterministic builds

Original change's description:
> Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration."
> 
> This reverts commit 9b5b52cbc622a593c0b58c9e963d8feaee0f6274 with the fix.
> 
> The fix is additional CROS_WORKON_SUBTREE entry (camera/include).
> The directory contains shared header files, which are accessed during
> the build.
> 
> BUG=chromium:803783,  chromium:920521 
> TEST=Ran try.
> CQ-DEPEND=CL:1404786
> 
> Change-Id: I6d0e3b953ff497649b102477527b1fad4751cff4
> Reviewed-on: https://chromium-review.googlesource.com/1404882
> Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Bug: chromium:803783,  chromium:920521 
Change-Id: I4db2a749491dfa14c7a6ba97613ef91352792744
Reviewed-on: https://chromium-review.googlesource.com/c/1413170
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/fafb6a126a8b33364ab4731c9a901f172736cb22/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/fafb6a126a8b33364ab4731c9a901f172736cb22/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eeff9de71875d9f1b0d5b570e9298080b2bf6a70

commit eeff9de71875d9f1b0d5b570e9298080b2bf6a70
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Jan 15 23:37:05 2019

Revert "Reland "camera: Migrate platform/arc-camera into platform2/camera.""

This reverts commit 731531ca1e122e4849b47f540489b02915cad735.

Reason for revert: non-deterministic build breakage

Original change's description:
> Reland "camera: Migrate platform/arc-camera into platform2/camera."
> 
> This reverts commit 4f60316c28a4c9070d43f4dd2c092525fc530de9 with the fix.
> 
> The fix is to add CROS_WORKON_SUBTREE entry (camera/include) to
> arc-camera-service. The directory contains shared header files,
> which are accessed during the build.
> 
> BUG=chromium:803783,  chromium:920521 
> TEST=Ran try.
> CQ-DEPEND=CL:1404457, CL:1404882
> 
> Change-Id: Ic0203920336a52a4fd122779e010de8e8576471c
> Reviewed-on: https://chromium-review.googlesource.com/1404786
> Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Ricky Liang <jcliang@chromium.org>

Bug: chromium:803783,  chromium:920521 
Change-Id: Ic87a46a41004c7fb2b917e91f8031666c8df40bd
Reviewed-on: https://chromium-review.googlesource.com/c/1413610
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/eclass/cros-camera.eclass
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/chromeos-base/cros-camera/cros-camera-9999.ebuild

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 19 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0

commit 509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Jan 19 08:13:34 2019

Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration."

This reverts commit fafb6a126a8b33364ab4731c9a901f172736cb22.

This is simple relanding of the reverted CL due to the tree breakage.
The actual fix for the problem is in CL:1414255.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1414255, CL:1414511

Change-Id: Ic0d907b8f4bea347afa787e12f006c78a3b053ba
Reviewed-on: https://chromium-review.googlesource.com/1414530
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 19 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/785cc4821df48b41be707da86bb820d2dcb77305

commit 785cc4821df48b41be707da86bb820d2dcb77305
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Jan 19 08:13:34 2019

camera: Reland "camera: Migrate platform/arc-camera into platform2/camera."

This reverts commit eeff9de71875d9f1b0d5b570e9298080b2bf6a70.

This is simple relanding of the reverted CL due to the tree breakage.
The actual fix for the problem is in CL:1414255.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1414530, CL:1414255

Change-Id: Ieb0a42c7c4024fa2961ec325c6c7b6657de14a6e
Reviewed-on: https://chromium-review.googlesource.com/1414511
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/eclass/cros-camera.eclass
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/chromeos-base/cros-camera/cros-camera-9999.ebuild

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 19 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/42744c62d07d1209595a153c4ec25af734a43ba5

commit 42744c62d07d1209595a153c4ec25af734a43ba5
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Jan 19 08:13:33 2019

camera: Update platform2 related paths.

This reverts commit 9fe2dec9926e921379764a798a1884e509df67c3.
and then add more fixes.

The repository platform/arc-camera is migrated into platform2/camera,
but some paths in the code was not updated and kept as they were relative
to old path.

Also, some of the paths contain "../../platform2/common-mk" to refer it
from "platform/arc-camera". It should work from the new location, but
"../platform2" is redundant now.
Specifically, it could cause build issue if out-of-tree build
does not work due to crbug.com/916471.
The actual problematic scenario we hit was written in  crbug.com/922274 #4.
Thus, the redundant "../platform2" is removed as the fix for it,
which is the diff from the reverted CL.

BUG= chromium:920521 , chromium:803783
TEST=Ran try.
CQ-DEPEND=CL:1414530, CL:1414511

Change-Id: I8d8a7d9398b8e3aacf997063030ed76d85327c38
Reviewed-on: https://chromium-review.googlesource.com/1414255
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcamera_ipc.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/hal/usb/libcamera_hal.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/PRESUBMIT.cfg
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/jpeg/libjda_test.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcab_test.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcbm.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/hal_adapter/cros_camera_service.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcab.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/hal/usb_v1/arc_camera_service.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/build/cros-camera-common.gypi
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/camera3_test/cros_camera_test.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcamera_common.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/jpeg/libjea_test.gyp

Sign in to add a comment