CommitQueueSync: Incorrect author for CL if there is an "Author" line in commit message |
|
Issue descriptionhttps://chrome-internal-review.googlesource.com/c/chromeos/vendor/mali-ddk/+/781015 This CL is authored by "Manoj Gupta <manojgupta@google.com>", but there is a: "Author: Vitaly Buka <vitalybuka@google.com>" in the commit message, and CQ incorrectly labels the CL as authored by Vitaly: CHUMP | mali-ddk | vitalybuka | 781015 Very minor issue, but we should probably only look at the first "Author" line for each CL. Also, there should be a * before 781015, since this is an internal repo.
,
Jan 10
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1404607 sync_stages/lkgm_manager: Fix git log parsing https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1404608 sync_stages/lkgm_manager: Fix internal chumped CL display
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b138a27ea79899d5fb6bda5fce6a9d4c67d96825 commit b138a27ea79899d5fb6bda5fce6a9d4c67d96825 Author: Nicolas Boichat <drinkcat@chromium.org> Date: Fri Jan 11 21:32:16 2019 sync_stages/lkgm_manager: Fix git log parsing git log --pretty=full has the "Author"/"Commit" lines unindented, fix the regex to match that. This fixes the issue where there is a line that says "Author: ..." in the commit message, and the regex picks the wrong author. Also, fix the unit tests to provide more correct input, and input that would catch the second case. BUG=chromium:920511 TEST=./run_tests --debug cbuildbot/lkgm_manager_unittest Change-Id: Ice403eafe4b97b60bccb41515f4d1330506281ef Reviewed-on: https://chromium-review.googlesource.com/1404607 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/b138a27ea79899d5fb6bda5fce6a9d4c67d96825/cbuildbot/lkgm_manager_unittest.py [modify] https://crrev.com/b138a27ea79899d5fb6bda5fce6a9d4c67d96825/cbuildbot/lkgm_manager.py |
|
►
Sign in to add a comment |
|
Comment 1 by drinkcat@chromium.org
, Jan 10Status: Started (was: Untriaged)