New issue
Advanced search Search tips

Issue 920479 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 709494



Sign in to add a comment

LazyLoad: VisibleLoadTime metrics are recorded for data URI images

Project Member Reported by sclit...@chromium.org, Jan 10

Issue description

Currently, it looks like VisibleLoadTime metrics are recorded for data URI images. Instead, Chrome should only record VisibleLoadTime metrics for http/https images, since those are the only kinds of images that would actually be lazily loaded.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae9f8d7d2e54fdbef4ea9c88e153339334f8b26

commit dae9f8d7d2e54fdbef4ea9c88e153339334f8b26
Author: Scott Little <sclittle@chromium.org>
Date: Thu Jan 10 21:53:16 2019

LazyLoad: Only lazily load http/https images.

Before this CL, data URI images would be considered for lazy loading,
even though a data URI image would actually be loaded immediately
anyways and not get deferred. For image elements, this pollutes the
Blink.VisibleLoadTime.LazyLoadImages.* metrics with load times of all
these data URI images that aren't actually eligible for lazy loading.
For CSS background images, this causes Chrome to begin montoring the
elements containing these images with an intersection observer until the
user scrolls the viewport down to them, even though the data URI image
loads instantly.

This CL changes the logic to only consider http/https images for lazy
loading, both for image elements and CSS background images.

Bug:  920479 
Change-Id: I105db546695c3464789703769013fa955f3bf10c
Reviewed-on: https://chromium-review.googlesource.com/c/1404575
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621758}
[modify] https://crrev.com/dae9f8d7d2e54fdbef4ea9c88e153339334f8b26/third_party/blink/renderer/core/css/css_image_value.cc
[modify] https://crrev.com/dae9f8d7d2e54fdbef4ea9c88e153339334f8b26/third_party/blink/renderer/core/loader/image_loader.cc

Status: Fixed (was: Started)

Sign in to add a comment