[Detachables] Minimized windows are blank on restore in tablet mode |
||||||||||||||
Issue descriptionChrome Version: 72.0.3626.49 (11316.66.0) Devices: Nocturne & Soraka Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Connect the external keyboard to the slate and open Chrome browser and Files app (2) Minimize the Chrome browser and Files apps (3) Detach the slate from keyboard and try to open Chrome browser and Files app and observe Expected Result: The app content should be displayed Actual Result: Apps are displayed blank with black screen How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? User should close the app from shelf and reopen it Please provide any additional information below. Attach a screen shot or log if possible. Issue is reproduced only in the devices which are detachable. i.e Nocturne and Soraka devices For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 10
weifangsun, could you please triage this, seems related to the files app.
,
Jan 10
Seems to be a general window manager issue. Also repros using the text app. And also if you open the text app then chrome.
,
Jan 10
Also repros then you create a shortcut from a website with the "open in window" checkbox, and also repros if you open the play store and chrome.
,
Jan 10
I've also managed to repro this on eve stable channel: Google Chrome 71.0.3578.85 (Official Build) beta (64-bit) Revision 059f9330a4505a7d00542f318aeb499decbd159d-refs/branch-heads/3578@{#868} Platform 11151.51.0 (Official Build) beta-channel eve
,
Jan 10
weidongg, did you look at minimized windows recently? I see issue 912973 . From the video this looks like a tablet mode window switching problem. Specifically the window is minimized before the transition into tablet mode. Also, I don't know if it matters that the home screen is visible before trying to restore. Retitling, because I think it's more likely that the app windows aren't restoring, rather than they are restoring and not painting. I can't repro this exact problem on ToT on linux-chromeos, but sometimes I can get into a state where a minimized browser window does not restore properly. Interesting the cursor changes to the text caret when I hover approximately where the new tab page text input field should be, so maybe the web contents is in the right place, but not painting for some reason? +estade, msw in case this sounds familiar.
,
Jan 10
Looks like something Sammie can work on. WidgetDelegateView of the files app has opacity 0 when it's showing as black.
,
Jan 10
I can repro on yesterday's ToT on device and linux-chromeos, in both classic ash, and SingleProcessMash.
,
Jan 11
Tracked down to [1]. I'm not sure why the opacity is 0, but a quick fix would be to set the opacity to 1 if its minimized. Investigating a bit further. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1292050
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aa1c73fef9de7113851349df372ad57fa21dd0a commit 4aa1c73fef9de7113851349df372ad57fa21dd0a Author: Sammie Quon <sammiequon@google.com> Date: Fri Jan 11 21:56:14 2019 cros: Fix issue with window being black if minimized before tablet mode. Issue was: 1) Open two windows in clamshell, minimize both. 2) Enter tablet. 3) Activate both windows, second window will be a black screen. It seems minimizing in clamshell mode sets opacity to 0. So force opacity to 1 before activate to ensure visiblity. Test: manual Bug: 920463 Change-Id: I3858ca4ac771d23879678f8705b73a281df0b8ac Reviewed-on: https://chromium-review.googlesource.com/c/1406243 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#622171} [modify] https://crrev.com/4aa1c73fef9de7113851349df372ad57fa21dd0a/ash/app_list/home_launcher_gesture_handler.cc
,
Jan 11
,
Jan 12
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 14
+djmm for permissions
,
Jan 14
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30076f29355e0879d17f5b9236591d820ab14a0b commit 30076f29355e0879d17f5b9236591d820ab14a0b Author: Sammie Quon <sammiequon@google.com> Date: Tue Jan 15 00:51:31 2019 [merge to 72] cros: Fix issue with window being black if minimized before tablet mode. Issue was: 1) Open two windows in clamshell, minimize both. 2) Enter tablet. 3) Activate both windows, second window will be a black screen. It seems minimizing in clamshell mode sets opacity to 0. So force opacity to 1 before activate to ensure visiblity. TBR=sammiequon@google.com (cherry picked from commit 4aa1c73fef9de7113851349df372ad57fa21dd0a) Test: manual Bug: 920463 Change-Id: I3858ca4ac771d23879678f8705b73a281df0b8ac Reviewed-on: https://chromium-review.googlesource.com/c/1406243 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622171} Reviewed-on: https://chromium-review.googlesource.com/c/1410365 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#682} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/30076f29355e0879d17f5b9236591d820ab14a0b/ash/app_list/home_launcher_gesture_handler.cc
,
Jan 15
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 30076f29355e0879d17f5b9236591d820ab14a0b was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30076f29355e0879d17f5b9236591d820ab14a0b Commit: 30076f29355e0879d17f5b9236591d820ab14a0b Author: sammiequon@google.com Commiter: sammiequon@chromium.org Date: 2019-01-15 00:51:31 +0000 UTC [merge to 72] cros: Fix issue with window being black if minimized before tablet mode. Issue was: 1) Open two windows in clamshell, minimize both. 2) Enter tablet. 3) Activate both windows, second window will be a black screen. It seems minimizing in clamshell mode sets opacity to 0. So force opacity to 1 before activate to ensure visiblity. TBR=sammiequon@google.com (cherry picked from commit 4aa1c73fef9de7113851349df372ad57fa21dd0a) Test: manual Bug: 920463 Change-Id: I3858ca4ac771d23879678f8705b73a281df0b8ac Reviewed-on: https://chromium-review.googlesource.com/c/1406243 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622171} Reviewed-on: https://chromium-review.googlesource.com/c/1410365 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#682} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 15
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by spathangi@chromium.org
, Jan 10