ToTWinThinLTO64 fails compile with duplicate symbol void __cdecl ui::VerifyKeyEvent |
|
Issue descriptionProblem can be reproduced locally using ninja event_unittests. Link to build or pfq page: https://ci.chromium.org/buildbot/chromium.clang/ToTWinThinLTO64 build # for that buildbot: 3059 https://ci.chromium.org/buildbot/chromium.clang/ToTWinThinLTO64/3059 Snippet of log that contains the failure: [33027/53752] LINK events_unittests.exe events_unittests.exe.pdb FAILED: events_unittests.exe events_unittests.exe.pdb ninja -t msvc -e environment.x64 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./events_unittests.exe /PDB:./events_unittests.exe.pdb @./events_unittests.exe.rsp lld-link: error: duplicate symbol: "void __cdecl ui::VerifyKeyEvent(class ui::KeyEvent *, enum ui::KeyboardCode, enum ui::DomCode, bool, bool)" (?VerifyKeyEvent@ui@@YAXPEAVKeyEvent@1@W4KeyboardCode@1@W4DomCode@1@_N3@Z) in obj/ui/events/events_unittests/media_keyboard_hook_win_unittest.obj and in obj/ui/events/events_unittests/modifier_keyboard_hook_win_unittest.obj
,
Jan 16
(6 days ago)
Patch: http://crrev.com/c/1406176
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17dce0a1df0e398d515443179766c875705666c8 commit 17dce0a1df0e398d515443179766c875705666c8 Author: inglorion <inglorion@chromium.org> Date: Wed Jan 16 22:52:07 2019 fix VerifyKeyEvent duplicate symbol errors Some builds were failing with duplicate symbol errors about VerifyKeyEvent. This symbol is defined by two files and each definition is only used inside the file that contains it. This change moves both definitions into an anonymous namespace so that they are no longer externally visible, avoiding the build errors. BUG=920451 Change-Id: Ic4be2f17930d0d19c10d807f65a7d7bfd6bc3edf Reviewed-on: https://chromium-review.googlesource.com/c/1406176 Reviewed-by: Joe Downing <joedow@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#623421} [modify] https://crrev.com/17dce0a1df0e398d515443179766c875705666c8/ui/events/win/media_keyboard_hook_win_unittest.cc [modify] https://crrev.com/17dce0a1df0e398d515443179766c875705666c8/ui/events/win/modifier_keyboard_hook_win_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by inglorion@chromium.org
, Jan 10