Only making a separate bug because this is a huge change.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/15ee5f53c6a9575492b79e353a5a9f5ae817342c commit 15ee5f53c6a9575492b79e353a5a9f5ae817342c Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Mon Jan 14 21:15:57 2019 BuildStore: Redirect GetBuildStatus through BuildStore Redirects CIDB GetBuildStatus(), GetBuildStatuses(), GetBuildStatusesWithBuildbucketIds() calls in cbuildbot/stages/*_stages.py through BuildStore.GetBuildStatuses(). Separate CLs will follow targeting other calls. BUG=chromium:920430 TEST=tryjob Change-Id: I35a51a0bc0713610303bdefe1f6648f217ecd5ea Reviewed-on: https://chromium-review.googlesource.com/1405769 Commit-Ready: Jason Clinton <jclinton@chromium.org> Tested-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/lib/buildstore.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/lib/fake_cidb.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/handle_changes_stages.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/build_stages.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/handle_changes_stages_unittest.py [modify] https://crrev.com/15ee5f53c6a9575492b79e353a5a9f5ae817342c/cbuildbot/stages/report_stages.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5587a0d79ff054811137802e2e8363d6b166bfb5 commit 5587a0d79ff054811137802e2e8363d6b166bfb5 Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Jan 15 06:03:10 2019 Revert "BuildStore: Redirect GetBuildStatus through BuildStore" This reverts commit 15ee5f53c6a9575492b79e353a5a9f5ae817342c. Reason for revert: Pre-CQ failing: crbug.com/921903 Original change's description: > BuildStore: Redirect GetBuildStatus through BuildStore > > Redirects CIDB GetBuildStatus(), GetBuildStatuses(), > GetBuildStatusesWithBuildbucketIds() calls in > cbuildbot/stages/*_stages.py through > BuildStore.GetBuildStatuses(). Separate CLs will follow > targeting other calls. > > BUG=chromium:920430 > TEST=tryjob > > Change-Id: I35a51a0bc0713610303bdefe1f6648f217ecd5ea > Reviewed-on: https://chromium-review.googlesource.com/1405769 > Commit-Ready: Jason Clinton <jclinton@chromium.org> > Tested-by: Jason Clinton <jclinton@chromium.org> > Reviewed-by: Jason Clinton <jclinton@chromium.org> Bug=chromium:920430 Bug= chromium:921903 Change-Id: I83afc086b32622b2dcf992755fa1713b59b64e12 Reviewed-on: https://chromium-review.googlesource.com/c/1409629 Tested-by: Shuhei Takahashi <nya@chromium.org> Trybot-Ready: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dhanya Ganesh <dhanyaganesh@chromium.org> [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/lib/buildstore.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/lib/fake_cidb.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/handle_changes_stages.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/build_stages.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/handle_changes_stages_unittest.py [modify] https://crrev.com/5587a0d79ff054811137802e2e8363d6b166bfb5/cbuildbot/stages/report_stages.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/cb90365294055af6c2dcbdfec80cd65d97df1d97 commit cb90365294055af6c2dcbdfec80cd65d97df1d97 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Wed Jan 16 20:30:44 2019 BuildStore: Redirect GetBuildStatus through BuildStore Redirects CIDB GetBuildStatus(), GetBuildStatuses(), GetBuildStatusesWithBuildbucketIds() calls in cbuildbot/stages/*_stages.py through BuildStore.GetBuildStatuses(). Separate CLs will follow targeting other calls. BUG=chromium:920430 TEST=tryjob Change-Id: I4ec1291c1a3a433db3d542d16ed1044da5747f76 Reviewed-on: https://chromium-review.googlesource.com/1412618 Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/lib/buildstore.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/lib/buildstore_unittest.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/lib/fake_cidb.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/handle_changes_stages.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/build_stages.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/handle_changes_stages_unittest.py [modify] https://crrev.com/cb90365294055af6c2dcbdfec80cd65d97df1d97/cbuildbot/stages/report_stages.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88 commit 5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Thu Jan 17 20:18:25 2019 BuildStore: Replace cidb handle argument to buildstore This change will make it easier to redirect CIDB calls to BuildStore eventually. Args replaced in SlaveStatus, BuildSpecsManager and LKGMManager. Added a few updates in cli/cros_uprevchrome and cli/chros_buildresult. BUG=chromium:920430 TEST=tryjob CQ-DEPEND=CL:1412618 Change-Id: Ia48d5de05abb6ccbfca27883bc55f5b6c34df2b2 Reviewed-on: https://chromium-review.googlesource.com/1407809 Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cli/cros/cros_uprevchrome_unittest.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/lkgm_manager_unittest.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cli/cros/cros_uprevchrome.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/manifest_version.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/build_status_unittest.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cli/cros/cros_buildresult.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/build_status.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/lib/buildstore.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/lkgm_manager.py [modify] https://crrev.com/5cfe5f2c7b78d0145fb4e8d5e17fe0876a67df88/cbuildbot/stages/chrome_stages.py
Comment 1 by bugdroid1@chromium.org
, Jan 14