New issue
Advanced search Search tips

Issue 920429 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: 10
NextAction: ----
OS: Chrome
Pri: 1
Type: Task

Blocked on:
issue 920430

Blocking:
issue 904578



Sign in to add a comment

Redirect CIDB functions to BuildStore

Project Member Reported by dhanyaganesh@chromium.org, Jan 9

Issue description

To eventually shift read accesses, we need to make sure that all CIDB functions to be retained are called through BuildStore. This process is already completed for InsertBuild and InsertBuildStage.
 
EstimatedDays: 10
Blockedon: 920430
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fdf6b7d8b45cc51b5f51ec9732de8994ad80b406

commit fdf6b7d8b45cc51b5f51ec9732de8994ad80b406
Author: Dhanya Ganesh <dhanyaganesh@chromium.org>
Date: Sat Jan 19 04:05:18 2019

BuildStore: Redirect UpdateMetadata function through BuildStore.

BuildStore will be the interface for all DB calls.

BUG=chromium:920429
TEST=tryjob

Change-Id: I5b1d3a6cf3ada7d17ae6ddf185d483c8798900db
Reviewed-on: https://chromium-review.googlesource.com/1416413
Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org>
Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/fdf6b7d8b45cc51b5f51ec9732de8994ad80b406/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/fdf6b7d8b45cc51b5f51ec9732de8994ad80b406/lib/buildstore_unittest.py
[modify] https://crrev.com/fdf6b7d8b45cc51b5f51ec9732de8994ad80b406/lib/buildstore.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b6ff570c11f2ebf31805975df8a5945e22662f4f

commit b6ff570c11f2ebf31805975df8a5945e22662f4f
Author: Dhanya Ganesh <dhanyaganesh@chromium.org>
Date: Sat Jan 19 08:14:01 2019

TriageRelevantChanges: Use buildstore instead of cidb handle

Change TriageRelevantChanges to accept buildstore instead of
cidb handle.

BUG=chromium:920429
TEST=run_tests

Change-Id: I521f51260732ee34fbfc0c39c2862f4e74779ff0
Reviewed-on: https://chromium-review.googlesource.com/1410159
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/b6ff570c11f2ebf31805975df8a5945e22662f4f/cbuildbot/relevant_changes_unittest.py
[modify] https://crrev.com/b6ff570c11f2ebf31805975df8a5945e22662f4f/cbuildbot/relevant_changes.py
[modify] https://crrev.com/b6ff570c11f2ebf31805975df8a5945e22662f4f/cbuildbot/build_status.py

Sign in to add a comment