New issue
Advanced search Search tips

Issue 920424 link

Starred by 1 user
Status: Assigned
Owner:
tiborg@chromium.org
Cc:
bialpio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR-AR
Proj-XR

Blocked on:
issue 862707


Sign in to add a comment

Remove package_arcore GN variable

Project Member Reported by ddorwin@chromium.org, Jan 9 
package_arcore was added to allow Chrome to selectively ship ARCore support to dev and canary while binary size issues were worked out. The solution for this is the AR DFM (862707).

According to tiborg, package_arcore really means package ARCore into the Monochrome APK and bundle builds always package ARCore support. (ARCore is not supported on older APK types.)

Thus, once the bundles and the AR DFM are enabled for all Chrome channels, we no longer need to worry about including ARCore support in the Monochrome APK and can remove package_arcore.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d13f0f57596b2d4fdafc3cfa21675498dc3203f

commit 4d13f0f57596b2d4fdafc3cfa21675498dc3203f
Author: David Dorwin <ddorwin@chromium.org>
Date: Fri Jan 18 19:57:40 2019

Update comments for enable_arcore and package_arcore

The crbugs were outdated, including one related to the fixed ARM64 issue
(841389).
Also clarify that package_arcore is not used for bundle builds.

Bug: 841389, 920424
Change-Id: I28ed40d12a4942ea230666910ee169d47d42d8ff
Reviewed-on: https://chromium-review.googlesource.com/c/1404477
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624249}
[modify] https://crrev.com/4d13f0f57596b2d4fdafc3cfa21675498dc3203f/device/vr/buildflags/buildflags.gni
►

Sign in to add a comment