New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 920408 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

nocturne: build fails SignerTest starting with 11445.0 - ImageSigningError: ('Security checks failed'

Project Member Reported by bleung@chromium.org, Jan 9

Issue description

Cc: moragues@chromium.org abhishekbh@chromium.org djaklich@chromium.org
Cc: drinkcat@chromium.org npoojary@chromium.org martinroth@chromium.org
Adding sheriffs for visibility
Here's the failure in SignerTest

https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8924816009172793216/+/steps/SignerTest/0/stdout

sed: -e expression #1, char 75: Invalid back reference
Unexpected kernel parameters found:
  snd_soc_dmic.modeswitch_delay_ms=35 

I'll fix it.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/852b89749fdb2618c2cf357d1d81f9b64cb805d7

commit 852b89749fdb2618c2cf357d1d81f9b64cb805d7
Author: Benson Leung <bleung@google.com>
Date: Thu Jan 10 01:49:31 2019

Revert "nocturne: set modeswitch_delay_ms=35 in kernel commandline"

This reverts commit 27e2929e4e86ef05e8f0ac5b64cce063baa1876a.

Reason for revert: Two problems.
1. This change landed without updating the whitelist in signer
   (see chromium:920408), so this broke signing recovery images for
   3 weeks.
2. modeswitch_delay_ms doesn't seem to be the right module param name.
   The one introduced in https://patchwork.kernel.org/patch/10702955/
   is "modeswitch_delay" so I'm convinced this change does nothing.

Original change's description:
> nocturne: set modeswitch_delay_ms=35 in kernel commandline
>
> Set snd_soc_dmic.modeswitch_delay_ms=35 in kernel command line to enable
> a delay between DMIC mode change. This is to enable the new module param
> introduced in patch https://patchwork.kernel.org/patch/10702955/
>
> BUG=b:117679624
> TEST=Verify DMIC capture on nocturne after cold reboot
>
> Change-Id: Ia4d40a92c497152f63fe22de1328a6bbe6cf2646
> Signed-off-by: Jenny TC <jenny.tc@intel.com>
> Reviewed-on: https://chromium-review.googlesource.com/1381297
> Commit-Ready: Nick Vaccaro <nvaccaro@google.com>
> Tested-by: Nick Vaccaro <nvaccaro@google.com>
> Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

Signed-off-by: Benson Leung <bleung@chromium.org>

Bug=b:117679624, chromium:920408 , chromium:917053 
TEST=SignerTest passes on nocturne canary (M-73).

Change-Id: I4bb6b64919992a8800fa89367166cdc5dcfa11d0
Reviewed-on: https://chromium-review.googlesource.com/c/1404356
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Trybot-Ready: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Bob Moragues <moragues@chromium.org>

[delete] https://crrev.com/51648c27ccfc458b5b53c9b0d1824f05b7a59180/overlay-nocturne/scripts/build_kernel_image.sh

Status: Fixed (was: Started)
11558.0 successfully passed SignerTest and signed properly.
Status: Verified (was: Fixed)

Sign in to add a comment