New issue
Advanced search Search tips

Issue 920404 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cleanup nebraska code for use in devserver

Project Member Reported by ahass...@chromium.org, Jan 9

Issue description

Some cleanups and addons are needed before deploying nebraska.
These changes include:

- Conform the json file to the one we generate for payload.json
- Add functions to nebraska to be able to use nebraska as a library instead of a server.
 
"- Add functions to nebraska to be able to use nebraska as a library instead of a server."

I wonder what will use nebraska as a library?
yep, :)
We can start by letting devserver generate the replies and remove the code that generate the replies from the devserver, then gradually deprecate major parts of devserver and replace it with the nebraska. Smoother transition basically!!
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/beb969106b25b8a279a045d1046bf49d566c13e6

commit beb969106b25b8a279a045d1046bf49d566c13e6
Author: Amin Hassani <ahassani@chromium.org>
Date: Sun Jan 13 21:52:14 2019

nebraska: Run only nebraska unittests

Add run_unittests to be able to easily run only nebraska unittests

BUG=chromium:920404
TEST=unittests

Change-Id: I660a53424d5f436b5b936352cc79b32e5d1e7106
Reviewed-on: https://chromium-review.googlesource.com/1404274
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[add] https://crrev.com/beb969106b25b8a279a045d1046bf49d566c13e6/nebraska/run_unittests

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/590be649d812c0624184027da0a915b5778f37d1

commit 590be649d812c0624184027da0a915b5778f37d1
Author: Amin Hassani <ahassani@chromium.org>
Date: Sun Jan 13 21:52:14 2019

nebraska: Rename some tags

Rename some tags to conform to what we generate in payload.json files
already. These changes include:
- AppData: version -> target_version
- AppData: src_version -> source_version
- AppData: metadata_sig -> metadata_signature
- AppData: hash_sha256 -> sha256_hex
- AppData: SHA256_HASH -> SHA256_HEX

BUG=chromium:920404
TEST=unittests
TEST='./nebraska --target-payloads=./' and sent a request and got a correct reply

Change-Id: Id6039121144d3d0ae7887597f5b98e3d23da37d5
Reviewed-on: https://chromium-review.googlesource.com/1404275
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[modify] https://crrev.com/590be649d812c0624184027da0a915b5778f37d1/nebraska/nebraska.py
[modify] https://crrev.com/590be649d812c0624184027da0a915b5778f37d1/nebraska/sample.json
[modify] https://crrev.com/590be649d812c0624184027da0a915b5778f37d1/nebraska/README.md
[modify] https://crrev.com/590be649d812c0624184027da0a915b5778f37d1/nebraska/appindex_unittest.py
[modify] https://crrev.com/590be649d812c0624184027da0a915b5778f37d1/nebraska/unittest_common.py
[modify] https://crrev.com/590be649d812c0624184027da0a915b5778f37d1/nebraska/response_unittest.py

Sign in to add a comment