New issue
Advanced search Search tips

Issue 920390 link

Starred by 2 users
Status: Assigned
Owner:
johnchen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver Is Element Displayed command fix

Project Member Reported by johnchen@chromium.org, Jan 9 
Requesting merge of https://chromium-review.googlesource.com/1403085 to m71 and m72 branches. This CL fixes a ChromeDriver bug that causes ChromeDriver Is Element Displayed command to work incorrectly with older version of shadow DOM. Some google3 users are affected by this issue, and are forced to stay with older version of ChromeDriver or Chrome as a result. This fix was originally done under  issue chromedriver:2728 .

Note that these changes are in ChromeDriver directory (src/third_party/webdriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Jan 9

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by abdulsyed@google.com, Jan 11

Labels: -Merge-Review-72 Merge-Approved-72
Approved for 72 - 3626
Project Member

Comment 3 by cr-audit...@appspot.gserviceaccount.com, Jan 11

Labels: -Merge-Approved-72 Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/55bc8ada40550688ac5c7f4d8b56058c0a087b76

Commit: 55bc8ada40550688ac5c7f4d8b56058c0a087b76
Author: johnchen@chromium.org
Commiter: johnchen@chromium.org
Date: 2019-01-11 03:10:38 +0000 UTC

[ChromeDriver] Fix Is Element Displayed in v0 shadow DOM

The Is Element Displayed command is broken when the element is inserted
into v0 shadow DOM through <content> element. The breakage happened when
code provided by Selenium was upgraded to support v1 shadow DOM.
In Chrome, the test for v1 shadow DOM returns true on a v0 shadow DOM,
but not the other way around. Thus it is necessary to test for v0 shadow
DOM before testing for v1.

Since support for v0 shadow DOM is expected to be removed from Chrome in
a few months, I'm resolving this issue by locally patching Selenium code,
instead of making the changes upstream.

Bug: chromium:920390,  chromedriver:2728 
Change-Id: I005ea64aeb8047a7626f764171acb5e6d6545a72
Reviewed-on: https://chromium-review.googlesource.com/c/1403085
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621287}(cherry picked from commit 61f9e60b2ec381cf3374cda30e4b3da8830b4a7b)
Reviewed-on: https://chromium-review.googlesource.com/c/1405652
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#638}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55bc8ada40550688ac5c7f4d8b56058c0a087b76

commit 55bc8ada40550688ac5c7f4d8b56058c0a087b76
Author: John Chen <johnchen@chromium.org>
Date: Fri Jan 11 03:10:38 2019

[ChromeDriver] Fix Is Element Displayed in v0 shadow DOM

The Is Element Displayed command is broken when the element is inserted
into v0 shadow DOM through <content> element. The breakage happened when
code provided by Selenium was upgraded to support v1 shadow DOM.
In Chrome, the test for v1 shadow DOM returns true on a v0 shadow DOM,
but not the other way around. Thus it is necessary to test for v0 shadow
DOM before testing for v1.

Since support for v0 shadow DOM is expected to be removed from Chrome in
a few months, I'm resolving this issue by locally patching Selenium code,
instead of making the changes upstream.

Bug: chromium:920390,  chromedriver:2728 
Change-Id: I005ea64aeb8047a7626f764171acb5e6d6545a72
Reviewed-on: https://chromium-review.googlesource.com/c/1403085
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621287}(cherry picked from commit 61f9e60b2ec381cf3374cda30e4b3da8830b4a7b)
Reviewed-on: https://chromium-review.googlesource.com/c/1405652
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#638}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/55bc8ada40550688ac5c7f4d8b56058c0a087b76/chrome/test/chromedriver/test/run_py_tests.py
[modify] https://crrev.com/55bc8ada40550688ac5c7f4d8b56058c0a087b76/chrome/test/data/chromedriver/shadow_dom_test.html
[modify] https://crrev.com/55bc8ada40550688ac5c7f4d8b56058c0a087b76/third_party/webdriver/atoms.cc
[modify] https://crrev.com/55bc8ada40550688ac5c7f4d8b56058c0a087b76/third_party/webdriver/patch.diff
►

Sign in to add a comment