New issue
Advanced search Search tips

Issue 920347 link

Starred by 2 users
Status: Fixed
Owner:
jbroman@chromium.org
Closed: Jan 10
Cc:
peter.wm...@gmail.com
yangguo@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Error: unrecognized flag --experimental_extras in content_shell

Project Member Reported by xiaoche...@chromium.org, Jan 9 
Chrome Version: ToT @ r620906
OS: Linux

What steps will reproduce the problem?
(1) Run "content_shell --run-web-tests editing/assert_selection.html"

The last parameter doesn't matter. Any page works for it.

What is the expected result?

Shouldn't see any error message.

What happens instead?

While the test passes, the follow error message is dumped:

Error: unrecognized flag --experimental_extras
Try --help for options
Error: unrecognized flag --experimental_extras
Try --help for options

As the flag is set in gin/v8_initializer.cc, assigned to Blink>Bindings for an initial look.

Comment 1 by jbroman@chromium.org, Jan 9

Cc: peter.wm...@gmail.com yangguo@chromium.org
Components: Blink>JavaScript
Owner: jbroman@chromium.org
Status: Assigned (was: Untriaged)
It looks like this flag was removed on the V8 side without the Blink use being removed, in this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1397906

(self-assigning for now, since peter.wm.wong can't be assigned as a bug owner)

I don't really understand what this did, but previously it was enabled whenever Blink was running with experimental web platform features. If it's no longer required, can you please remove the corresponding Blink and Gin plumbing? It wasn't clear to me how this was related to the original bug.

(I'm an owner for both, so I should be able to review such a CL quickly.)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9cbb397994c57f68027e97f12af3030f832668b

commit d9cbb397994c57f68027e97f12af3030f832668b
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Thu Jan 10 16:58:28 2019

v8: Remove obsolete V8 extras flag

Bug:  chromium:920347 
Tbr: avi@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,thestig@chromium.org
Change-Id: I6334a195d4804e07563c9a61fe771e005234b134
Reviewed-on: https://chromium-review.googlesource.com/c/1404554
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621611}
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/AUTHORS
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/content/test/fuzzer/fuzzer_support.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/extensions/renderer/bindings/api_binding_test.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/gin/isolate_holder.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/gin/public/isolate_holder.h
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/gin/shell/gin_main.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/gin/shell_runner_unittest.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/gin/test/v8_test.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/gin/v8_initializer.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/gin/v8_initializer.h
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/net/proxy_resolution/proxy_resolver_v8.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
[modify] https://crrev.com/d9cbb397994c57f68027e97f12af3030f832668b/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 3 by jbroman@chromium.org, Jan 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment