Changes to luci-milo.cfg trigger cq_cfg_presubmit warning on Windows |
|||
Issue description
Unsure of how this broke or who broke it. It could possibly have always been broken on Windows. Any change at all to luci-milo.cfg on Windows will trigger a spurious warning:
** Presubmit Warnings **
branch/cq_cfg_presubmit_unittest.py (0.84s) failed
FF.Regexp simple/file appears to have no valid files which could match it.
======================================================================
FAIL: test_verify_path_regexp_exists (__main__.CqCfgPresubmitTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "branch/cq_cfg_presubmit_unittest.py", line 19, in test_verify_path_regexp_exists
'simple/file',
AssertionError: False is not true
======================================================================
FAIL: test_verify_path_regexp_os_walk_found (__main__.CqCfgPresubmitTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "branch/cq_cfg_presubmit_unittest.py", line 34, in test_verify_path_regexp_os_walk_found
], False))
AssertionError: False is not true
----------------------------------------------------------------------
Ran 3 tests in 0.002s
FAILED (failures=2)
Stephen I see you wrote this presubmit. Can you help track down the problem here? Repro case here: https://crrev.com/c/1403346
,
Jan 9
,
Jan 9
Looking
,
Jan 9
Uploaded https://crrev.com/c/1403517, which should fix this. Can you try applying that patch locally to see if it fixes the problem?
,
Jan 9
Thanks for the fast response. I tried locally and now I only see one failure:
branch/cq_cfg_presubmit_unittest.py (0.90s) failed
.F.
======================================================================
FAIL: test_verify_path_regexp_os_walk_found (__main__.CqCfgPresubmitTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "branch/cq_cfg_presubmit_unittest.py", line 35, in test_verify_path_regexp_os_walk_found
], False))
AssertionError: False is not true
----------------------------------------------------------------------
Ran 3 tests in 0.003s
FAILED (failures=1)
,
Jan 9
Hmm ok, I uploaded another fix. Can you try applying the patch in https://crrev.com/c/1403517 again? If that doesn't work, I'll find a windows checkout myself and fiddle with it.
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0936f65693044e2c95cc9ab05b8642b7f8c1f919 commit 0936f65693044e2c95cc9ab05b8642b7f8c1f919 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Jan 09 23:01:55 2019 Fix cq_cfg_presubmit.py tests on windows This CL should fix the script to correctly handle paths on windows. Bug: 920290 Change-Id: I2012f84ad39db8a71d98e1de97f90eedbd31fed8 Reviewed-on: https://chromium-review.googlesource.com/c/1403517 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#621355} [modify] https://crrev.com/0936f65693044e2c95cc9ab05b8642b7f8c1f919/infra/config/branch/cq_cfg_presubmit.py [modify] https://crrev.com/0936f65693044e2c95cc9ab05b8642b7f8c1f919/infra/config/branch/cq_cfg_presubmit_unittest.py
,
Jan 10
Should be fixed.
,
Jan 10
Thanks for the fix! |
|||
►
Sign in to add a comment |
|||
Comment 1 by jmad...@chromium.org
, Jan 9