New issue
Advanced search Search tips

Issue 920264 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-21
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 915053

Blocking:
issue 829084



Sign in to add a comment

Investigate reducing binary size for LAPI scripts

Project Member Reported by domenic@chromium.org, Jan 9

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1394713 failed some initial CQ runs because of a binary size increase; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8925216238073142416/+/steps/Trybot_Results/0/logs/s_____Size_Assertion_Results____/0

It seems like there are at least two low-hanging fruits here:

- Figure out how to enable GZIP for LAPI resources. I tried adding compress="gzip" but it caused the tests to fail.
- Figure out how to enable minification for LAPI resources. IIRC it is disabled currently (wwith skip_minify="true") because our minifier does not support modern JavaScript.

I am unsure of the urgency of this. If I am reading the results right, the binary size increased by 13 bytes in that CL, so the failure seems like not a big deal. But presumably that check was put in place for a reason.

Assigning to hiroshige@ for his thoughts and potential work.
 
NextAction: 2019-01-21
Memo:
- I can/will enable GZIP.
- I think I have doc and/or crbug for minification, but couldn't find it immediately. I'll search further later.

Comment 3 by hirosh...@chromium.org, Jan 18 (5 days ago)

Blocking: 829084

Comment 4 by hirosh...@chromium.org, Jan 18 (5 days ago)

Blockedon: 915053
As for minification, Issue 915053 might be related, according to
https://bugs.chromium.org/p/chromium/issues/detail?id=839512#c5

Comment 5 by monor...@bugs.chromium.org, Yesterday (42 hours ago)

The NextAction date has arrived: 2019-01-21

Sign in to add a comment