Issue metadata
Sign in to add a comment
|
0.1%-1.1% regression in sizes at 621144:621154 |
||||||||||||||||||||
Issue descriptionRegression is about 4MB on Win and 7MB in linux.
,
Jan 9
Looking at the commit range [2] I suspect [1] which appears to be adding Dawn as an static dependency for Chromium. cwallez@ is this possible? [1]https://chromium.googlesource.com/chromium/src/+/16c01cdf959e8e9909f01491271a57bb5c5cb9eb [2] https://chromium.googlesource.com/chromium/src/+log/007850b95fe68fc29f2d615500d9a4e31d530da3%5E..f8119b9be8440b231a19c0b4019310cfa8065433?pretty=fuller&n=1000
,
Jan 9
This is extremely unlikely because that patch that was rolled adds compilation of static libraries but doesn't add them as dependencies of Chrome (and Chrome doesn't depend on any targets from that repo) https://chromium.googlesource.com/chromium/src/+/007850b95fe68fc29f2d615500d9a4e31d530da3 is more likely because it reverts a commit that was described as saving binary size in its commit message. Tentatively assigning fdoray@ and +CC jam@, though I suspect this will be won't fix because the change will be relanded eventually.
,
Jan 9
Relanded in 621215 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 9