New issue
Advanced search Search tips

Issue 920257 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.1%-1.1% regression in sizes at 621144:621154

Project Member Reported by majidvp@chromium.org, Jan 9

Issue description

Regression is about 4MB on Win and 7MB in linux.



 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=920257

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ef6f169abe8d9cc66f6625dc22149252fec0ffea3601d09d2873664e97a86575


Bot(s) for this bug's original alert(s):

Google Chrome Linux x64
Google Chrome Mac
Google Chrome Win
Owner: cwallez@chromium.org
Looking at the commit range [2] I suspect [1] which appears to be adding Dawn as an static dependency for Chromium. cwallez@ is this possible?



[1]https://chromium.googlesource.com/chromium/src/+/16c01cdf959e8e9909f01491271a57bb5c5cb9eb  

[2] https://chromium.googlesource.com/chromium/src/+log/007850b95fe68fc29f2d615500d9a4e31d530da3%5E..f8119b9be8440b231a19c0b4019310cfa8065433?pretty=fuller&n=1000
Cc: jam@chromium.org cwallez@chromium.org
Owner: fdoray@chromium.org
This is extremely unlikely because that patch that was rolled adds compilation of static libraries but doesn't add them as dependencies of Chrome (and Chrome doesn't depend on any targets from that repo)

https://chromium.googlesource.com/chromium/src/+/007850b95fe68fc29f2d615500d9a4e31d530da3 is more likely because it reverts a commit that was described as saving binary size in its commit message.

Tentatively assigning fdoray@ and +CC jam@, though I suspect this will be won't fix because the change will be relanded eventually.
Status: WontFix (was: Unconfirmed)
Relanded in 621215

Sign in to add a comment