Convert ntp4_browsertest.cc away from using SigninManager to set the primary account |
||
Issue descriptionFirst thing to figure out is whether this test (and production code) is used on ChromeOS. If it's not, we can just use PrimaryAccountsMutator. If it is, then we can use identity_test_utils.h to make the primary account available.
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e81757d81a68e4f7858e7a0e1bcd5b3c294154f7 commit e81757d81a68e4f7858e7a0e1bcd5b3c294154f7 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Wed Jan 16 02:22:46 2019 [s13n] Move NTP4LoggedInWebUITest away from using SigninManager Even though NTP4LoggedInWebUITest is disabled and it's not used any more, this CL removes SigninManager. SigninManager is going to be an implementation detail of IdentityManager. Bug: 920251 Change-Id: Iece55df48e53edcd4240f2f08b6fd49ab1af6f15 Reviewed-on: https://chromium-review.googlesource.com/c/1411194 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#623049} [modify] https://crrev.com/e81757d81a68e4f7858e7a0e1bcd5b3c294154f7/chrome/test/data/webui/ntp4_browsertest.cc
,
Jan 16
|
||
►
Sign in to add a comment |
||
Comment 1 by je_julie.kim@chromium.org
, Jan 14Status: Started (was: Available)