Eliminate need for ChromeRenderViewHostTestHarness to inject FakeSigninManager |
||
Issue descriptionFirst step here is to just eliminate its injection of FakeSigninManager, run it through the bots, and see how many failures there are. Report back on this CL when we have those results to analyze and we can determine what the approach is for eliminating the failures based on how many there are.
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/255f13035938876e8cdfd6d7d50579e1dfb40b4c commit 255f13035938876e8cdfd6d7d50579e1dfb40b4c Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Jan 10 19:16:29 2019 Eliminate injection of FakeSigninManager from ChromeRenderViewHostTestHarness::CreateBrowserContext Instead, the standard SigninManager instance created by TestingProfile::Builder is used. Subclasses that need it differently can override ChromeRenderViewHostTestHarness::CreateBrowserContext (many already do!) This allows us to get rid of many includes for SigninManager, PO2TS, GaiaCookieServiceManager, AccountTrackerService. BUG= 920249 Change-Id: I90624f05af2c99480bae7b0fcfc4e04fbaba7628 Reviewed-on: https://chromium-review.googlesource.com/c/1403161 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#621689} [modify] https://crrev.com/255f13035938876e8cdfd6d7d50579e1dfb40b4c/chrome/test/base/chrome_render_view_host_test_harness.cc
,
Jan 10
|
||
►
Sign in to add a comment |
||
Comment 1 by toniki...@chromium.org
, Jan 9Status: Started (was: Available)