New issue
Advanced search Search tips

Issue 920240 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Eliminate inline_login_ui_browsertest.cc's references to/inclusions of SigninManager

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

It looks like SetUpSigninManager() should just be inlined. The include looks stale.
 
Owner: gyuyo...@igalia.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac86e0cdbdec37fb0c48dddd300c7acde492c090

commit ac86e0cdbdec37fb0c48dddd300c7acde492c090
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Wed Jan 16 02:57:40 2019

s13n: Remove the usage of SigninManager in inline_login_ui_browsertest.cc

Clean up sign-in-related code in inline_login_ui_browsertest.cc and make
InlineLoginUIBrowserTest.CanOfferProfileConnected call IdentityManager directly
instead of calling SetUpSigninManager().

Bug:  920240 
Change-Id: I1723a388ee65109ae94cd3a889399cdbb68b155b
Reviewed-on: https://chromium-review.googlesource.com/c/1408716
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623074}
[modify] https://crrev.com/ac86e0cdbdec37fb0c48dddd300c7acde492c090/chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc

Comment 4 by gyuyo...@igalia.com, Jan 17 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment