Eliminate inline_login_ui_browsertest.cc's references to/inclusions of SigninManager |
|||
Issue descriptionIt looks like SetUpSigninManager() should just be inlined. The include looks stale.
,
Jan 14
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac86e0cdbdec37fb0c48dddd300c7acde492c090 commit ac86e0cdbdec37fb0c48dddd300c7acde492c090 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Wed Jan 16 02:57:40 2019 s13n: Remove the usage of SigninManager in inline_login_ui_browsertest.cc Clean up sign-in-related code in inline_login_ui_browsertest.cc and make InlineLoginUIBrowserTest.CanOfferProfileConnected call IdentityManager directly instead of calling SetUpSigninManager(). Bug: 920240 Change-Id: I1723a388ee65109ae94cd3a889399cdbb68b155b Reviewed-on: https://chromium-review.googlesource.com/c/1408716 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#623074} [modify] https://crrev.com/ac86e0cdbdec37fb0c48dddd300c7acde492c090/chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc
,
Jan 17
(6 days ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by gyuyo...@igalia.com
, Jan 14