New issue
Advanced search Search tips

Issue 920232 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Port bookmark_bubble_view_unittest.cc away from using FakeSigninManager

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

From the usage, it's not clear whether the SigninManager in question actually needs to be a FakeSigninManager. First try taking out the injection of the FakeSigninManager altogether as its own CL, as if we don't need it we also won't need to use IdentityTestEnvironment. If we *do* need it then we should port to use IdentityTestEnvironmentProfileAdaptor.
 
Owner: svil...@igalia.com
Status: Started (was: Available)
Taking this
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94fb1307c47c40f8c50d1cc03105e6d94d154e4c

commit 94fb1307c47c40f8c50d1cc03105e6d94d154e4c
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Mon Jan 14 10:31:53 2019

Port BookMarkBubbleView unit test away of using SigninManager

First of all we don't need to use a FakeSigninManager as it works fine
with the SigninManager created by the factory from the profile. We
then go further and replace the SigninManager API by the
IdentityManager API.

In order not to crash we must modify
ChromeSigninClient::GetInstallDate to deal with the case of a
BrowserProcess without MetricsService as it happens with the
TestingBrowserProcess for example. This modification is interesting
per se as the BrowserProcess::metrics_service() clearly states that it
might return nullptr.

Bug:  920232 
Change-Id: I15377fa9838e1975c4655a775add84973c65c71a
Reviewed-on: https://chromium-review.googlesource.com/c/1403416
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#622409}
[modify] https://crrev.com/94fb1307c47c40f8c50d1cc03105e6d94d154e4c/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/94fb1307c47c40f8c50d1cc03105e6d94d154e4c/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment