Port one_click_signin_sync_starter_unittest.cc away from SigninManager to IdentityManager |
|||||
Issue descriptionFrom the usage, it's not clear whether the SigninManager in question actually needs to be a FakeSigninManager. First try taking out the injection of the FakeSigninManager altogether as its own CL, as if we don't need it we also won't need to use IdentityTestEnvironment. If we *do* need it then we should port to use IdentityTestEnvironmentProfileAdaptor.
,
Jan 9
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fefd13936326516602394491dca553f0a020702a commit fefd13936326516602394491dca553f0a020702a Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Jan 10 13:44:33 2019 [s13n] Port one_click_signin_sync_starter_unittest.cc away from SigninManager to IdentityManager CL uses IdentityTestEnvironmentProfileAdaptor to create the profile (hiding FakeSigninManager, PO2TS, GaiaCookieManagerServer, et al), and uses IdentityTestEnvironment directly to replace SigninManager API calls. BUG= 920231 Change-Id: I499cb3e2fb94387c765ef088a6f23d500639c5c8 Reviewed-on: https://chromium-review.googlesource.com/c/1404234 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#621566} [modify] https://crrev.com/fefd13936326516602394491dca553f0a020702a/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc
,
Jan 10
,
Jan 10
reopening for a follow up
,
Jan 10
Work is done here (the follow up isn't needed since the file is under removal). |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by toniki...@chromium.org
, Jan 9