New issue
Advanced search Search tips

Issue 920226 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Remove SigninManager-related includes from signin_promo.cc

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Look unused.
 
Owner: gyuyo...@igalia.com
I'd like to take over this bug.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eabdd180c1699d037dc4f94932047289a16aad16

commit eabdd180c1699d037dc4f94932047289a16aad16
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Wed Jan 16 02:40:23 2019

s13n: Remove unnecessary signin_manager related includes in signin_promo.cc

This CL cleans up the unnecessary includes related to SigninManager.

Bug:  920226 
Change-Id: Id64f444591456e42da80abf26f0f03c6ef45fe4b
Reviewed-on: https://chromium-review.googlesource.com/c/1410712
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623061}
[modify] https://crrev.com/eabdd180c1699d037dc4f94932047289a16aad16/chrome/browser/signin/signin_promo.cc

Comment 3 by gyuyo...@igalia.com, Jan 17 (6 days ago)

Status: Fixed (was: Available)

Sign in to add a comment